| Summary: | Vertical non-icons-only Task Manager icons are larger than with Icons-Only Task Manager on a panel of identical thickness | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | zorba-kde |
| Component: | Task Manager and Icons-Only Task Manager widgets | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | minor | CC: | conorleyden, nate, niccolo.venerandi |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | 5.26.4 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/337c60b5821a503c198f072bc34b3c156f1fd811 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Vertical taskbar, icons too large.
Customized vertical taskbar icons even bigger Old versus New (20.5 v 26.5) |
||
|
Description
zorba-kde
2022-12-21 20:08:17 UTC
Created attachment 154733 [details]
Customized vertical taskbar
Apparently I just had to submit it! Now, of course, I can't edit my post. Anyway, customized vertical taskbar screenshot added; that's what I would like to add a config setting to achieve. This calls out for a slightly smaller size there, not an option. Git commit 337c60b5821a503c198f072bc34b3c156f1fd811 by Nate Graham. Committed on 11/01/2023 at 21:57. Pushed by ngraham into branch 'master'. applets/taskmanager: use default "medium" spacing for traditional task manager It was mistakenly using the "small" size for its margins, making icons effectively too big for their frame compared to the icons-only version. Changing the multiplier for the traditional task manager makes its margins match the default margins of the icons-only version. FIXED-IN: 5.27 M +2 -2 applets/taskmanager/package/contents/ui/code/layout.js https://invent.kde.org/plasma/plasma-desktop/commit/337c60b5821a503c198f072bc34b3c156f1fd811 Created attachment 155226 [details]
icons even bigger
This may be a result of me cherrypicking this change into my current version without any other possibly-related changes, but this actually makes my icons *larger*. If you think it's right, though, I'm happy to just wait to see what happens and keep using my original patch until then.
I guess it depends on what you think the right fix is: make the box bigger, or make the icons smaller. I went with the former, on the thinking that the margins were what was wrong, not the icon size. Ultimately it might make sense to allow customizing the size for Traditional Task Managers that are placed in a vertical panel, just like how we do for Icons-Only Task Managers. Created attachment 155351 [details]
Old versus New (20.5 v 26.5)
I'd say it just needs to go back to the way it was, I'd struggle to see the need for configuration. At least for me, the icon size is what was wrong. I move the taskbar to the side partly so I can have more visible and visually-identifiable programs open at once, along with reasonably long titles so I can distinguish stuff with similar names if I need to. Big icons means fewer programs, which, to me, defeats the point. It might be that this is a niche request (that's certainly what Microsoft decided :V) in which case I'll just live with my permanent local customizations. At the same time, I think there's *some* number of people who really hated the MS decision, and may be comfortable with a more Win10-ish design, and I think that's value in permitting that. At which point it's either "behave like that by default, annoying anyone who liked the old option" or "provide a little slider in the config options". Which I admit I'm still a fan of, as someone who would use that option, and not as someone who would have to maintain that option :) I may not have been clear, I meant the way it has been in KDE for over a decade up until recently, small icons & text. It's the combination of large icons and text that seems bizarre. Don't know when the change to large icons occurred but the above screenshot is from KDE 5.20. Git commit 8dc5e1926562139637363f5f9e6e8735234e2393 by Nate Graham. Committed on 17/01/2023 at 17:54. Pushed by ngraham into branch 'master'. Revert "applets/taskmanager: use default "medium" spacing for traditional task manager" This reverts commit 337c60b5821a503c198f072bc34b3c156f1fd811. This wasn't the right fix, as it makes the icons larger and decreases space efficiency. M +2 -2 applets/taskmanager/package/contents/ui/code/layout.js https://invent.kde.org/plasma/plasma-desktop/commit/8dc5e1926562139637363f5f9e6e8735234e2393 |