Bug 463245

Summary: Exchange rates converter no longer works
Product: [Applications] skrooge Reporter: Nicola Feltrin <n.feltrin>
Component: generalAssignee: Stephane MANKOWSKI <stephane>
Status: RESOLVED FIXED    
Severity: normal CC: stephane
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: 25.1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Nicola Feltrin 2022-12-19 18:34:15 UTC
SUMMARY
The exchange rates source `exchangeratesapi.io` no longer works, i.e. it no longer allows creation of API keys for new subscribers, redirecting instead to `https://apilayer.com`. The APIs there are not fully compatible with the original ones.
This means that new users (without API keys for the old service) cannot successfully setup rate conversion for multiple currencies.
The problem is made worse by the fact that all other exchange rates sources seem to be equally broken (or worse).

STEPS TO REPRODUCE
1. Try use the `exchangeratesapi.io` plugin with a key from `apilayer.com`
2. Hit "Download" button
3. Error message appears "[ERR-5]: Download failed"

OBSERVED RESULT
An error message appears stating that download was not possible

EXPECTED RESULT
Exchange rates are being downloaded and used within the program

SOFTWARE/OS VERSIONS
Windows: ---
macOS: ---
Linux/KDE Plasma: 5.26.4
(available in About System)
KDE Plasma Version: 5.26.4
KDE Frameworks Version: 5.101.0
Qt Version: 5.15.7

ADDITIONAL INFORMATION
I'm trying to create a separate source for apilayer, might need some support/feedback on the contribution :)
Comment 1 Stephane MANKOWSKI 2022-12-19 21:58:26 UTC
Git commit c45b0abf7f3630be860bb29e5d7e90b031d860b5 by Stephane MANKOWSKI.
Committed on 19/12/2022 at 21:58.
Pushed by smankowski into branch 'master'.

Exchange rates converter no longer works

M  +1    -0    skgbankmodeler/CMakeLists.txt
A  +26   -0    skgbankmodeler/skrooge-exchangerates_apilayer.py
A  +82   -0    skgbankmodeler/sources/org.kde.skrooge-source-exchangerates_apilayer.desktop

https://invent.kde.org/office/skrooge/commit/c45b0abf7f3630be860bb29e5d7e90b031d860b5
Comment 2 Nicola Feltrin 2022-12-20 08:30:40 UTC
(In reply to Stephane MANKOWSKI from comment #1)
> Git commit c45b0abf7f3630be860bb29e5d7e90b031d860b5 by Stephane MANKOWSKI.
> Committed on 19/12/2022 at 21:58.
> Pushed by smankowski into branch 'master'.
> 
> Exchange rates converter no longer works
> 
> M  +1    -0    skgbankmodeler/CMakeLists.txt
> A  +26   -0    skgbankmodeler/skrooge-exchangerates_apilayer.py
> A  +82   -0   
> skgbankmodeler/sources/org.kde.skrooge-source-exchangerates_apilayer.desktop
> 
> https://invent.kde.org/office/skrooge/commit/
> c45b0abf7f3630be860bb29e5d7e90b031d860b5

That was _way_ too fast :D thank you very much!