| Summary: | Plasma session restore no longer opens files in kwrite | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | tguen <tguenther.dev> |
| Component: | kwrite | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugs.kde.attila, christoph, kloecker, local10, wolfgang.illmeyer |
| Priority: | NOR | ||
| Version First Reported In: | 22.12.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/kate/commit/a6c64ff86e9815b3f719880442dd9242f60380e6 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
tguen
2022-12-17 00:25:20 UTC
Am having the same (or similar) issue. After a recent upgrade (kwrite:amd64 4:22.04.3-1 -> 4:22.12.0-2) Kwrite no longer remembers what files it had open before logging out of KDE or rebooting the PC. If I had, for example, two files open in Kwrite in two separate windows before logging out of KDE, when logged back into KDE, KDE would open two empty Kwrite windows instead of properly showing the files that used to be in those windows. Other apps (for example, Okular) properly open files they had open before logging out of KDE after logging back into KDE. Operating System: Debian 12 Bookworm GNU/Linux KDE Plasma Version: 5.26.4 KDE Frameworks Version: 5.100.0 Qt Version: 5.15.6 Kernel Version: 6.0.0-6-amd64 (64-bit) Graphics Platform: X11 ADDITIONAL INFORMATION https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026307 This looks very much like a regression of the new tab support in KWrite. On the first login after the upgrade to 22.12, I had hoped that this is just a one-off problem because each instance of KWrite now has to remember a list of open documents instead of just one document. But apparently, this is just broken and not just an upgrade issue. Does the session restore work for Kate? Yes, for Kate it works as good as before the upgrade regardless of whether I use a named session or just a bunch of files. Hmm, ok, then I must have messed that up with some of the few divergences for KWrite mode. I skipped some restore steps but thought that should only affect the not used mdi stuff... Could you try if this commit is the reason for that! https://invent.kde.org/utilities/kate/-/commit/5dac26e2b7747aab9a97a4eb516a83990d2122ed If somebody would try that, I could fix and backport it, else it stays broken. (In reply to Christoph Cullmann from comment #8) > If somebody would try that, I could fix and backport it, else it stays > broken. I'm interested in the fix so I'd try it if you provide the affected lib/executable file to try with the instructions how to apply it. Don't have any setup to build KDE from source. I tried your fix on the master branch and it solved the problem for me. (In reply to Wolfgang Illmeyer from comment #10) > I tried your fix on the master branch and it solved the problem for me. Thanks a lot for the testing. Git commit 4082f64a9695287ee87c712ef1287fabe8ee8c9b by Christoph Cullmann. Committed on 29/12/2022 at 13:26. Pushed by cullmann into branch 'master'. Fix session restore for KWrite M +6 -2 apps/lib/katemainwindow.cpp M +6 -1 apps/lib/katemainwindow.h M +4 -10 apps/lib/kateviewmanager.cpp M +3 -1 apps/lib/session/katesessionmanager.cpp https://invent.kde.org/utilities/kate/commit/4082f64a9695287ee87c712ef1287fabe8ee8c9b Git commit a6c64ff86e9815b3f719880442dd9242f60380e6 by Christoph Cullmann. Committed on 29/12/2022 at 13:33. Pushed by cullmann into branch 'release/22.12'. Fix session restore for KWrite (cherry picked from commit 4082f64a9695287ee87c712ef1287fabe8ee8c9b) M +6 -2 apps/lib/katemainwindow.cpp M +6 -1 apps/lib/katemainwindow.h M +4 -10 apps/lib/kateviewmanager.cpp M +3 -1 apps/lib/session/katesessionmanager.cpp https://invent.kde.org/utilities/kate/commit/a6c64ff86e9815b3f719880442dd9242f60380e6 *** Bug 463720 has been marked as a duplicate of this bug. *** |