Bug 463110

Summary:	Layer lock does not prevent moving selected parts of layer
Product:	[Applications] krita	Reporter:	rebuilderster
Component:	Tools/Move	Assignee:	Tiar <tamtamy.tymona>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla, tamtamy.tymona
Priority:	NOR
Version First Reported In:	5.1.1
Target Milestone:	---
Platform:	Mint (Ubuntu based)
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/36573abc8c6ddd22b339d8f8c3da26da5bf5db1a	Version Fixed/Implemented In:
Sentry Crash Report:

Description rebuilderster 2022-12-16 10:54:49 UTC

SUMMARY
If a layer is locked, the user can still make a selection and move the pixels selected.

STEPS TO REPRODUCE
1. Create a layer and draw something in it
2. Lock the layer
3. make a selection and use the move tool to move the pixels you have selected

OBSERVED RESULT
The selected pixels are moved

EXPECTED RESULT
Nothing should happen, since the layer is locked.

Comment 1 Halla Rempt 2022-12-16 11:09:41 UTC

Thanks for the report, I can confirm the issue.

Comment 2 Tiar 2023-03-17 17:01:13 UTC

Git commit 36573abc8c6ddd22b339d8f8c3da26da5bf5db1a by Agata Cacko.
Committed on 17/03/2023 at 17:00.
Pushed by tymond into branch 'master'.

Prevent moving selected parts of a locked layer

Before this commit, Move Tool could still move selected part
on a layer even if it was locked.
This commit prevents it from happening.

M  +10   -1    plugins/tools/basictools/kis_tool_move.cc

https://invent.kde.org/graphics/krita/commit/36573abc8c6ddd22b339d8f8c3da26da5bf5db1a