| Summary: | Feedback KCM page appears even if its KCM isn't installed | ||
|---|---|---|---|
| Product: | [Applications] Welcome Center | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-welcome/commit/fa6bba7de2a4077e6c8a77bf8016e98f6e321173 | Version Fixed/Implemented In: | 5.27 |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2022-12-09 02:35:02 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-welcome/-/merge_requests/25 Git commit fa6bba7de2a4077e6c8a77bf8016e98f6e321173 by Nate Graham. Committed on 10/12/2022 at 21:50. Pushed by ngraham into branch 'master'. Don't show User Feedback page if KUserFeedback isn't available Some distros patch this out (e.g. openSUSE) so for them, we don't want to show the user a blank and broken-looking page. This commit handles that case appropriately by marking KUserFeedback as an optional dependency, and only embedding its KCM if it's found. FIXED-IN: 5.27 M +1 -0 CMakeLists.txt M +3 -0 src/CMakeLists.txt M +4 -2 src/contents/ui/main.qml M +10 -0 src/controller.cpp M +1 -0 src/controller.h A +7 -0 src/kuserfeedbacksettings.h.cmake https://invent.kde.org/plasma/plasma-welcome/commit/fa6bba7de2a4077e6c8a77bf8016e98f6e321173 |