Bug 462678

Summary:	KDE Invent Continuous Integration falsely determines degradation of code quality
Product:	[I don't know] kde	Reporter:	Alexander Wilms <f.alexander.wilms>
Component:	general	Assignee:	Unassigned bugs <unassigned-bugs-null>
Status:	RESOLVED UPSTREAM
Severity:	normal	CC:	bcooksley, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Alexander Wilms 2022-12-05 16:21:31 UTC

SUMMARY
Part of the Continuous Integration steps that are run after each commit of a merge request at https://invent.kde.org is the code quality check.

However, this check always finds fault with a decrease in code quality even in files, which a particular merge request didn't even touch. This makes the check basically worthless, since one cannot easily discern between actual issues introduced by a commit and old ones.

STEPS TO REPRODUCE
1. Fork a repo at https://invent.kde.org
2. Make a small, non-breaking change
3. Submit a merge

OBSERVED RESULT
"Code quality degraded due to 489 new issues"

EXPECTED RESULT
No detected degradation of code quality

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version:DE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Examples:

https://invent.kde.org/graphics/okular/-/merge_requests/669
https://invent.kde.org/graphics/skanlite/-/merge_requests/33
https://invent.kde.org/system/dolphin/-/merge_requests/466

Comment 1 Alexander Wilms 2022-12-05 17:23:54 UTC

The cppcheck CI config is hosted here:

Repository: https://invent.kde.org/sysadmin/ci-utilities
run-cpp check.py: https://invent.kde.org/sysadmin/ci-utilities/-/blob/master/run-cppcheck.py

Comment 2 Ben Cooksley 2022-12-06 07:49:53 UTC

The actual comparison of the reports is carried out by Gitlab itself, so this is a bug within Gitlab.

Comment 3 Nate Graham 2022-12-06 16:32:35 UTC

Yep, that was my conclusion as well. Alexander, you'll need to report this in GitLab's monster bug tracker at https://gitlab.com/gitlab-org/gitlab/-/issues. Once you do, can you paste the URL of your issue here, in the URL field of this bug report? Thanks!