| Summary: | Brush Editor - Sliders' horizontal width extends beyond screen edge | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | sooz <ouestfleur> |
| Component: | * Unknown | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla, ouestfleur, penguinflyer2222, pinknalu |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Android | ||
| OS: | Android 11.x | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Screenshot of Brush Editor opened on tablet - Android 11 | ||
Confirming that the brush editor is much wider than before on git 6051d462. Reverting every commit in MR!1653 "Made the widget KisResourceItemChooser support narrow horizontal layout" corrects it, specifically reverting the initial commit, 3cdfbb58 (https://invent.kde.org/graphics/krita/-/merge_requests/1653/diffs?commit_id=3cdfbb5874de10e074c749bc018446c848bd414b). I suspect that it's the use of KisPresetSelectorStrip in the brush preset editor that causes the problem. This class actually was already doing what the changes in the relevant MR did: it provided a horizontal or vertical preset chooser strip with two scroll buttons. (It is currently only used in vertical mode, and I don't know why we're still using that class instead of KisPresetChooser directly. (Though I guess that simply embedding KisPresetChooser would not solve the problem yet.) Hi Sooz, Could you check whether the current nightly build from https://binary-factory.kde.org/ fixes the issue? Dmitry thinks it should've been fixed... Thank you. It's back to normal width. Thanks for your comment! Automatically switching the status of this bug to REPORTED so that the KDE team knows that the bug is ready to get confirmed. In the future you may also do this yourself when providing needed information. I'm changing this to resolved as the width is back to normal. This is the 1st time I ever reported a bug so let me know if I've overstepped by changing the status. Reopening a bug developers have closed is a no-no, marking a bug as fixed after testing is great! |
Created attachment 154255 [details] Screenshot of Brush Editor opened on tablet - Android 11 SUMMARY 5.2.0-prealpha git 6051d46 on Android 11 Brush editor is unusable due to sliders extending beyond screen edge. STEPS TO REPRODUCE 1. Open brush editor 2. Try to use scratchpad or save brush edits 3. OBSERVED RESULT 75% of brush editor is visible, 25% on the right is off screen. EXPECTED RESULT Entire brush editor displayed on screen, all functions available. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION Reported by Sooz from the K-A forum.