Bug 462511

Summary: Urls surrounded by <> are not detected
Product: [Applications] konsole Reporter: zarisase
Component: emulationAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/utilities/konsole/commit/a48e4deab23de1283f89aea49bf8037412daede1 Version Fixed In:
Sentry Crash Report:

Description zarisase 2022-12-01 16:41:33 UTC 
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Type in `<google.com>`
2. While holding Ctrl, hover over the google.com

OBSERVED RESULT
The link isn't detected

EXPECTED RESULT
The link is detected

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 5.26
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Konsole version is 22.08.
iTerm2 detects this properly.
Comment 1 zarisase 2022-12-01 17:14:15 UTC 
Sorry, try <https://google.com>
Comment 2 Bug Janitor Service 2022-12-01 22:51:52 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/780
Comment 3 Kurt Hindenburg 2022-12-10 08:17:26 UTC 
Git commit 2e84af9400409021fe1ad64e7e56f2c5a0e6f82f by Kurt Hindenburg, on behalf of Luis Javier Merino Morán.
Committed on 10/12/2022 at 08:11.
Pushed by hindenburg into branch 'master'.

url filter: start regex with word boundary

This allows recognizing more kinds of enclosed URIs, e.g:

 - angle brackets: <https://example.com>
 - lenticular brackets: 【https://example.com】
 - braces: {https://example.com}
 - guillemets: «https://example.com»
 - single guillemets ‹https://example.com›
 - ...

and also URIs right after an equals sign, e.g: foo=https://example.com.
Related: bug 455166

M  +6    -0    src/autotests/HotSpotFilterTest.cpp
M  +1    -1    src/filterHotSpots/UrlFilter.cpp

https://invent.kde.org/utilities/konsole/commit/2e84af9400409021fe1ad64e7e56f2c5a0e6f82f
Comment 4 Kurt Hindenburg 2022-12-30 18:04:26 UTC 
Git commit a48e4deab23de1283f89aea49bf8037412daede1 by Kurt Hindenburg, on behalf of Luis Javier Merino Morán.
Committed on 30/12/2022 at 16:49.
Pushed by hindenburg into branch 'release/22.12'.

url filter: start regex with word boundary

This allows recognizing more kinds of enclosed URIs, e.g:

 - angle brackets: <https://example.com>
 - lenticular brackets: 【https://example.com】
 - braces: {https://example.com}
 - guillemets: «https://example.com»
 - single guillemets ‹https://example.com›
 - ...

and also URIs right after an equals sign, e.g: foo=https://example.com.
Related: bug 455166

M  +6    -0    src/autotests/HotSpotFilterTest.cpp
M  +1    -1    src/filterHotSpots/UrlFilter.cpp

https://invent.kde.org/utilities/konsole/commit/a48e4deab23de1283f89aea49bf8037412daede1