Bug 462406

Summary:	Changing lift gamma gain by clicking and holding creates multiple undo history entries. Requires many undo commands to reverse
Product:	[Applications] kdenlive	Reporter:	Darwin McGrath <darwin>
Component:	Video Effects & Transitions	Assignee:	Vincent PINON <vpinon>
Status:	RESOLVED FIXED
Severity:	normal	CC:	erjiang
Priority:	NOR
Version First Reported In:	22.08.3
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	https://invent.kde.org/multimedia/kdenlive/-/commit/79dae6dcd0c81d94956aa58b17fde752cc121eb3	Version Fixed/Implemented In:
Sentry Crash Report:

Description Darwin McGrath 2022-11-29 19:30:17 UTC

SUMMARY
***
Changing lift gamma or gain sliders or gamma or gain "dots" results in a long chain of undo history elements when there should be a single entry upon release of the mouse button. Undoing effect adjustment requires many undo commands.
***


STEPS TO REPRODUCE
1. Apply Lift gamma gain effect 
2. Move a slider or dot by clicking, dragging, and releasing with the mouse.


OBSERVED RESULT
Large string of undo entries in undo history


EXPECTED RESULT
Single entry, allowing a single undo command to reverse the change.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Ubuntu 22.04.1 LTS
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 erjiang 2022-12-07 04:13:57 UTC

Was able to reproduce this on Mac (release/22.12, built on 2022-11-25) as described.

Comment 2 Jean-Baptiste Mardelle 2023-09-25 16:40:51 UTC

Git commit 48515473d3d2d3b193dee7342585be9ae13fee66 by Jean-Baptiste Mardelle.
Committed on 25/09/2023 at 18:40.
Pushed by mardelle into branch 'master'.

Fix multiple issues with Lift/Gamma/Gain undo
Related: bug 472865

M  +2    -2    src/assets/keyframes/model/keyframemodel.cpp
M  +2    -1    src/assets/keyframes/model/keyframemodel.hpp
M  +17   -0    src/assets/keyframes/model/keyframemodellist.cpp
M  +9    -1    src/assets/keyframes/model/keyframemodellist.hpp
M  +61   -0    src/assets/model/assetcommand.cpp
M  +23   -0    src/assets/model/assetcommand.hpp
M  +38   -19   src/assets/view/widgets/colorwheel.cpp
M  +4    -3    src/assets/view/widgets/colorwheel.h
M  +13   -13   src/assets/view/widgets/keyframewidget.cpp
M  +13   -7    src/assets/view/widgets/lumaliftgainparam.cpp
M  +4    -4    src/assets/view/widgets/lumaliftgainparam.hpp
M  +10   -0    src/utils/qcolorutils.cpp
M  +3    -0    src/utils/qcolorutils.h

https://invent.kde.org/multimedia/kdenlive/-/commit/48515473d3d2d3b193dee7342585be9ae13fee66

Comment 3 Jean-Baptiste Mardelle 2023-10-03 13:23:51 UTC

Git commit 79dae6dcd0c81d94956aa58b17fde752cc121eb3 by Jean-Baptiste Mardelle.
Committed on 03/10/2023 at 11:27.
Pushed by mardelle into branch 'release/23.08'.

Fix multiple issues with Lift/Gamma/Gain undo
Related: bug 472865

M  +2    -2    src/assets/keyframes/model/keyframemodel.cpp
M  +2    -1    src/assets/keyframes/model/keyframemodel.hpp
M  +17   -0    src/assets/keyframes/model/keyframemodellist.cpp
M  +9    -1    src/assets/keyframes/model/keyframemodellist.hpp
M  +61   -0    src/assets/model/assetcommand.cpp
M  +23   -0    src/assets/model/assetcommand.hpp
M  +38   -19   src/assets/view/widgets/colorwheel.cpp
M  +4    -3    src/assets/view/widgets/colorwheel.h
M  +13   -13   src/assets/view/widgets/keyframewidget.cpp
M  +13   -7    src/assets/view/widgets/lumaliftgainparam.cpp
M  +4    -4    src/assets/view/widgets/lumaliftgainparam.hpp
M  +10   -0    src/utils/qcolorutils.cpp
M  +3    -0    src/utils/qcolorutils.h

https://invent.kde.org/multimedia/kdenlive/-/commit/79dae6dcd0c81d94956aa58b17fde752cc121eb3