| Summary: | Snippet popup appears when I type the `.` | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Peter Tselios <ptselios> |
| Component: | plugin-snippets | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/kate/-/commit/ebb30fb1bdb6813fa371fa98622002980cbfebce | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
katepartrc
katerc |
||
|
Description
Peter Tselios
2022-11-29 07:45:02 UTC
Created attachment 154130 [details]
katerc
An interesting point found in Reddit :) https://www.reddit.com/r/kde/comments/z6usov/comment/iy9wstz/?utm_source=reddit&utm_medium=web2x&context=3 A possibly relevant merge request was started @ https://invent.kde.org/utilities/kate/-/merge_requests/1321 Git commit ebb30fb1bdb6813fa371fa98622002980cbfebce by Christoph Cullmann, on behalf of Gary Li. Committed on 17/10/2023 at 19:01. Pushed by cullmann into branch 'master'. Do not popup snippets based on editor text with default implementation M +12 -0 addons/snippets/snippetcompletionmodel.cpp M +1 -1 addons/snippets/snippetcompletionmodel.h https://invent.kde.org/utilities/kate/-/commit/ebb30fb1bdb6813fa371fa98622002980cbfebce A possibly relevant merge request was started @ https://invent.kde.org/utilities/kate/-/merge_requests/1644 Git commit a8463f8761d35701803367c38b416dbb724e015e by Christoph Cullmann, on behalf of Waqar Ahmed. Committed on 09/11/2024 at 13:11. Pushed by cullmann into branch 'master'. Fix snippets not working unless completion is hard invoked They should not be completely disabled unless someone hard presses ctrl-space as it makes the experience very annoying. Overtime one can get used to the annoyance but I am not sure its a good idea. The new logic honors ktexteditor minimal word length and starts the completion if the last char is a letter. This should avoid the issue with snippet completion starting on pressing `.`. However, this might still be too simplistic but we can refine on it instead of hard disabling the feature Related: bug 495416 M +14 -8 addons/snippets/snippetcompletionmodel.cpp https://invent.kde.org/utilities/kate/-/commit/a8463f8761d35701803367c38b416dbb724e015e Git commit 3a9e858c71cbd8a5021e73cb86fc52a7e5fa2b15 by Waqar Ahmed. Committed on 17/11/2024 at 08:02. Pushed by waqar into branch 'release/24.12'. Fix snippets not working unless completion is hard invoked They should not be completely disabled unless someone hard presses ctrl-space as it makes the experience very annoying. Overtime one can get used to the annoyance but I am not sure its a good idea. The new logic honors ktexteditor minimal word length and starts the completion if the last char is a letter. This should avoid the issue with snippet completion starting on pressing `.`. However, this might still be too simplistic but we can refine on it instead of hard disabling the feature Related: bug 495416 (cherry picked from commit a8463f8761d35701803367c38b416dbb724e015e) M +14 -8 addons/snippets/snippetcompletionmodel.cpp https://invent.kde.org/utilities/kate/-/commit/3a9e858c71cbd8a5021e73cb86fc52a7e5fa2b15 |