Bug 462348

Summary:	Crash when click Open Externally if image is not loaded
Product:	[Applications] NeoChat	Reporter:	Gary Wang <wzc782970009>
Component:	General	Assignee:	Tobias Fella <fella>
Status:	RESOLVED WORKSFORME
Severity:	crash	CC:	carl, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Gary Wang 2022-11-28 11:50:18 UTC

SUMMARY

When an image is not properly loaded, right clicking and choose "Open Externally" will cause NeoChat crash.

STEPS TO REPRODUCE
1. Open a chat with image that not loaded (either not finish loading or load failed)
2. Right clicking and choose "Open Externally"
3. See the result

OBSERVED RESULT

NeoChat crashed (stacktrace: https://invent.kde.org/-/snippets/2428)

EXPECTED RESULT

Not sure if there is a correct behavior if the image is not loaded properly since in this case there will be no local file that can be opened, but at least NeoChat shouldn't crash.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux (rolling)
KDE Frameworks Version: 5.100.0
Qt Version: 5.15.7
libQuotient: 0.7.0 (with E2EE enabled, commit SHA: 16668c4cb4703ac26fe3a58e471a522ad95e1547)
NeoChat: commit SHA: d07066e5405d4d49fc00793433cb00445dacd308

ADDITIONAL INFORMATION

NeoChat build with kdesrc-build. All images are not able to load properly on my Arch Linux machine (so I originally want to right click and see if I can copy a URL and open it in a browser), but on Windows Nightly build the image can be loaded properly. A working socks5 proxy is set since I cannot access the matrix server without a proxy (not sure if that's related). Let me know if you need any additional information.

Comment 1 Gary Wang 2022-11-29 05:18:53 UTC

Additionally:

When building with libquotient 0.6.11 (0.6.11-1 from Arch Linux repo), even if the image/sticker is still not able to load properly, NeoChat won't crash. The crash only happen if I build it with libquotient 0.7 (dev branch with the revision provided above).

Comment 2 Tobias Fella 2023-05-04 11:42:35 UTC

Can't reproduce, does that still happen for you?

Comment 3 Bug Janitor Service 2023-05-19 03:46:00 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 4 Bug Janitor Service 2023-06-03 03:45:23 UTC

This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!