| Summary: | using bookmarks should clear command line first | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Ferdinand Gassauer <gassauer> |
| Component: | bookmark | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | adaptee, shafff |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/konsole/693cecbae73896f03a1c47f4c41a0fa30759d917 | Version Fixed In: | 4.10.0 |
| Sentry Crash Report: | |||
|
Description
Ferdinand Gassauer
2002-08-07 20:05:27 UTC
Thank you for your bug report. The feature that you requested has been implemented in the latest development (CVS) version of KDE. The feature request will be closed. does NOT work in HEAD and KDE31_BRANCH any more For a reason, it's now not broken anymore for all who have no emacs shell keybindings. its still a problem in CVS I use bash - never used emacs after typing cd and hitting a bookmark I get gassauer@linuxfg3:~> cd cd '/d2/src/gassauer.cvs/kde2/' bash: cd: cd: No such file or directory I didn't understand Comment #3. What is konsole to do if there is a program running on the current session? Currently it sends the 'cd whereever' to that program. How would it "clear" the command line? I'm not sure konsole should do anything other than what it is doing now. well it did it correctly before i issued the bug report For reference:
00638void KBookmarkOwner::openBookmarkURL( constQString& url )
00639 {
00640 (void) new KRun(KURL( url ));
00641 }
So, KRun(KURL("file:///mnt/part6/build/kdebase/konsole/konsole/"));
Perhaps, overwrite
void KBookmarkOwner::openBookmarkURL ( const QString & _url ) [virtual]
to clear prompt and then call KRun ourselves...
http://mail.gnome.org/archives/mc-devel/2006-July/msg00013.html http://mail.gnome.org/archives/mc-devel/2006-July/msg00063.html Comments on mc trying to tell if there is anything currently on the command line. See 161637 - think it is a bug, not wish. Another issue is what to do when the foreground process is not a shell? Sending 'cd /path/to/folder' or 'ssh ...' into vim/mc/less does not make sense and might cause damage. That sounds a stupid operation but I think some (new) users might do that, because the current documentation does not contain clear explanation on how bookmark works. One possible way is checking which screen is in use: 1). If the secondary screen is in use, the foreground process is not a shell. Do nothing in this case. 2). If the primary screen is in use, the foreground process may be a shell with high probability. Do something as suggested in this report in this case. Git commit 693cecbae73896f03a1c47f4c41a0fa30759d917 by Kurt Hindenburg. Committed on 26/06/2012 at 15:30. Pushed by hindenburg into branch 'master'. Clear command line before outputting bookmark entry. Keep a list of valid programs (shells) that accept Ctrl+C to clear the command line. Clear command line only when there is no active program running and a valid program is being ran. REVIEW: 105298 FIXED-IN: 4.10.0 M +12 -0 src/SessionController.cpp M +2 -0 src/SessionController.h http://commits.kde.org/konsole/693cecbae73896f03a1c47f4c41a0fa30759d917 |