Bug 462322

Summary: Unable to Add Custom Effect to Project Bin Clips or Master
Product: [Applications] kdenlive Reporter: Ziflin <ziflin>
Component: Video Effects & TransitionsAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal CC: fritzibaby, jb
Priority: NOR    
Version First Reported In: 22.08.3   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/multimedia/kdenlive/commit/57fa1a3e52df9994828dbaca473753e9dfdf5de1 Version Fixed/Implemented In: 22.12.0
Sentry Crash Report:

Description Ziflin 2022-11-27 18:17:23 UTC 
SUMMARY

After making a custom effect (stack) with only White Balance and Exposure effects, I'm unable to add them to entire clips in the Project Bin or to the Master track (I can add them to individual tracks and clips inside the timeline). I was greatly hoping to add these custom effects to *just*  the clips as I have many sliced clips in the timeline from a single original clip and this would save a good bit of time (140 files vs 400+ timeline clips).

STEPS TO REPRODUCE

1. Create a project and import a few clips into the Project Bin.
2. Select a clip in the bin and add a White Balance and Exposure effect to it.
3. Click the "Save Effect Stack..." button in the Effect Stack and give it a name.
4. Select another clip in the project bin and drag & drop or double click the newly created custom effect from the Effects panel.  (Or select the Mast Effect Stack and attempt to add the custom effect there.)

OBSERVED RESULT

An error pops up in the bottom status bar that states "Cannot add effect to clip"

EXPECTED RESULT

The effects should be added to the effect stack for the project bin clip or master track.

SOFTWARE/OS VERSIONS
Windows: 11
Comment 1 emohr 2022-11-28 19:49:51 UTC 
I can confirm the issue following your steps. Custom effects can only be applied to picture in the project bin but not to video clips.
Comment 2 Jean-Baptiste Mardelle 2022-11-28 21:13:34 UTC 
Git commit 57fa1a3e52df9994828dbaca473753e9dfdf5de1 by Jean-Baptiste Mardelle.
Committed on 28/11/2022 at 21:13.
Pushed by mardelle into branch 'release/22.12'.

Fix cannot add effect group to bin clip or master.
FIXED-IN: 22.12.0

M  +24   -16   src/effects/effectstack/model/effectstackmodel.cpp

https://invent.kde.org/multimedia/kdenlive/commit/57fa1a3e52df9994828dbaca473753e9dfdf5de1
Comment 3 emohr 2022-11-29 15:45:48 UTC 
Thanks, it’s fixed. Now I can drop custom effects on clips in the project bin or on master effect.