Bug 462186

Summary:	Discover shows packages from disabled pacman repos, but download button is stuck on "Loading..."
Product:	[Applications] Discover	Reporter:	annoyingrain5
Component:	PackageKit	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	CONFIRMED ---
Severity:	normal	CC:	aleixpol, arojas, matthias, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description annoyingrain5 2022-11-24 01:59:45 UTC

SUMMARY
Discover shows packages from disabled pacman repos without any message noting this.
Good example would be Steam being listed when the multilib repo (arch 32 bit packages) isn't enabled.

STEPS TO REPRODUCE
1. Disable a pacman repo, or use a system where one is already disabled, refresh package lists via pacman -Sy if needed. (disable multilib for this example, but works with other repos)
2. Open discover and find a package that is only on the disabled repo (search for Steam in this example)
3. Observe as the download button is stuck on "Loading..."

OBSERVED RESULT
The download button says "Loading..." and is unable to be clicked

EXPECTED RESULT
The download button states that multilib must be enabled in order to download the package, or a message appears when clicking on it

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.26.3
KDE Frameworks Version: 5.100.0
Qt Version: 5.15.7

Comment 1 Aleix Pol 2022-12-01 00:26:49 UTC

I know why it happens, not sure how to address this.

Maybe we could make sure that when "appstreamcli refresh" happens, appstream knows which components are disabled? Then it would be a matter of refreshing the appstream database when the repos change.

Adding Antonio from ArchLinux and Matthias from AppStream, for ideas.

Comment 2 Antonio Rojas 2022-12-01 08:52:02 UTC

It would be good to still show these apps in Discover with a warning that they are from a disabled repo (that is how one would "discover" apps after all). But I don't know if it is at all possible to distinguish this case from the case of an app which is removed from the repos and is still present in the appstream data (which is perfectly possible since the appstream data is only updated ~once a month)

Comment 3 Matthias Klumpp 2022-12-01 18:22:22 UTC

This issue might be the same as https://github.com/PackageKit/PackageKit/issues/573

Comment 4 Antonio Rojas 2022-12-01 18:27:45 UTC

(In reply to Matthias K. from comment #3)
> This issue might be the same as
> https://github.com/PackageKit/PackageKit/issues/573

Not really, I'm pretty sure that is just a duplicate of https://github.com/PackageKit/PackageKit/issues/533