| Summary: | Floating panel ignores margin | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | dS810 <artem.anufrij> |
| Component: | Panel | Assignee: | veggero <niccolo.venerandi> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, niccolo.venerandi |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/12c258d531deb2fb6700e320d87463df1c948664 | Version Fixed/Implemented In: | 5.26.5 |
| Sentry Crash Report: | |||
| Attachments: |
Right panel
Settings |
||
Can you include a screenshot whilst in edit mode of that particular panel? Created attachment 153940 [details]
Settings
Can reproduce A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2352 Git commit 9d90c7105a91748c6767f7abf758a4f597a2d5c0 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 02/12/2022 at 23:07. Pushed by ngraham into branch 'master'. Panel: Add floating margins to avoid overflowing content when floating This is because we're adding the floating margin *inside* the panel's window, which means that the actual length of the panel ends up being (content length - floating margins). I'm just adding them back when we calculate the size of the panel. FIXED-IN: 5.26.5 M +2 -2 shell/panelview.cpp https://invent.kde.org/plasma/plasma-workspace/commit/9d90c7105a91748c6767f7abf758a4f597a2d5c0 Git commit 12c258d531deb2fb6700e320d87463df1c948664 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 02/12/2022 at 23:08. Pushed by ngraham into branch 'cherry-pick-9d90c710'. Panel: Add floating margins to avoid overflowing content when floating This is because we're adding the floating margin *inside* the panel's window, which means that the actual length of the panel ends up being (content length - floating margins). I'm just adding them back when we calculate the size of the panel. FIXED-IN: 5.26.5 (cherry picked from commit 9d90c7105a91748c6767f7abf758a4f597a2d5c0) M +2 -2 shell/panelview.cpp https://invent.kde.org/plasma/plasma-workspace/commit/12c258d531deb2fb6700e320d87463df1c948664 |
Created attachment 153939 [details] Right panel As you can see, the WiFi icon on the right panel has no padding/margin to the right border (see Screenshot)