Summary: | [Recorder] "Input FPS" option accidentally influences the 'Duration' of end result/result preview | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | David REVOY <info> |
Component: | Dockers/Recorder | Assignee: | Reinold Rojas <rojasreinold> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | eoinoneill1991, rojasreinold |
Priority: | NOR | ||
Version First Reported In: | 5.1.3 | ||
Target Milestone: | --- | ||
Platform: | Appimage | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/a8f6ca21b04af5e58fa7cc29d8a1ddf9b0967f4e | Version Fixed In: | |
Sentry Crash Report: |
Description
David REVOY
2022-11-15 12:13:55 UTC
Hi David, Yes it works like you described and it seems the input fps is messing with duration of the preview and end result. I took a little bit of a look and I think it has something to do with how the framerate is set either for the input files or the export file. I'll try and look into this sometime this weekend. thanks for the detailed bug report. A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/2061 Git commit a8f6ca21b04af5e58fa7cc29d8a1ddf9b0967f4e by Dmitry Kazakov, on behalf of Reinold Rojas. Committed on 31/01/2024 at 08:44. Pushed by dkazakov into branch 'master'. Fixed recorder export being sped up by input fps Before this commit if a number higher than 30 was put for INPUT_FPS it would speed up the preview, preview transition, and extended result. This commit fixes the ffmpeg profiles so they properlly take into account the INPUT_FPS. M +23 -23 plugins/dockers/recorder/recorder_export_config.cpp https://invent.kde.org/graphics/krita/-/commit/a8f6ca21b04af5e58fa7cc29d8a1ddf9b0967f4e Thank you Reinold for the MR, and thank you Dmitry for the review and the merging. 👍 |