Bug 461835

Summary:	German "Buß- und Bettag" holiday is wrong (SN,BY)
Product:	[Frameworks and Libraries] frameworks-kholidays	Reporter:	Lamdarer <Lamdarer>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	carl, claudio.cambra, nate
Priority:	NOR
Version:	5.99.0
Target Milestone:	---
Platform:	Manjaro
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/kholidays/commit/8ceca1b8c7a8a61f6c69a0387674d575853b26b5	Version Fixed In:	5.102.0
Attachments:	Kalendar widget, Buß- und Bettag is at the 23.11.2022

Description Lamdarer 2022-11-14 19:49:27 UTC

Created attachment 153744 [details]
Kalendar widget, Buß- und Bettag is at the 23.11.2022

SUMMARY
***
German "Buß- und Bettag" holiday is wrong
***


STEPS TO REPRODUCE
1. Open the KDE Kalendar taskbar digtial clock widget
2. Go to settings, enable holidays
3. select de-sn_de or de-by_de (and possibly others, but I dont think so, at least not in germany)

OBSERVED RESULT
The holiday of Buß- und Bettag(https://en.wikipedia.org/wiki/Bu%C3%9F-_und_Bettag) is misplaced  to the 23.11.2022 but in fact it is the 16.11.2022

EXPECTED RESULT
This year it should be at the 16.11.2022, to quote the english Wikipedia article:"in other words, it is the Wednesday that falls between 16 and 22 November"

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Manjaro Linux
KDE Plasma Version: 5.26.3
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.7

ADDITIONAL INFORMATION
Are the taskbar and some kde windows supposed to restart/crash when disabling or enabling the holidays? Because thats what happened frequently during my tests(switching between different holidays etc).

Comment 1 Lamdarer 2022-11-16 11:03:41 UTC

So it is today, not next week. Seems that it is fine next year but the rule for generating this Holiday probably needs adjustment in order to stop misplacement in the future.

Comment 2 Claudio Cambra 2022-11-27 11:12:15 UTC

Hi, I am moving this to the plasmashell product bug section as Kalendar is the application, while the digital clock applet containing the calendar is separate

Comment 3 Nate Graham 2022-11-27 16:50:38 UTC

Holidays are defined in KHolidays; moving there.

Comment 4 Allen Winter 2022-12-17 12:45:19 UTC

Git commit 8ceca1b8c7a8a61f6c69a0387674d575853b26b5 by Allen Winter.
Committed on 17/12/2022 at 12:44.
Pushed by winterz into branch 'master'.

Fix German "Buß- und Bettag" holiday is wrong (SN,BY)
FIXED-IN: 5.102.0

M  +1    -1    holidays/plan2/holiday_de-by_de
M  +1    -1    holidays/plan2/holiday_de-sn_de

https://invent.kde.org/frameworks/kholidays/commit/8ceca1b8c7a8a61f6c69a0387674d575853b26b5