Summary: | After every reboot wallpaper changes to the first one in the Wallpaper Slideshow list, irrespective of the current wallpaper | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | shscs911 <mayavi.nair> |
Component: | Image Wallpaper | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate, notmart, oded, qydwhotmail |
Priority: | NOR | Keywords: | regression |
Version: | 5.26.0 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/51fdcd20a50712d6f5c4a88cbc02f167b3718528 | Version Fixed In: | 5.26.4 |
Sentry Crash Report: |
Description
shscs911
2022-11-06 08:37:14 UTC
The wallpaper path is not saved in the new plugin. (In reply to Fushan Wen from comment #1) > The wallpaper path is not saved in the new plugin. Is wallpaper reset the expected behaviour now or will it be considered as a bug to be fixed in a future release? Can't repro with current Neon unstable (Plasma 5.26.80, Frameworks 5.100.0). On the first reboot, after today's update, it showed the default Plasma wallpaper before fading into the slideshow (that does not include the Plasma wallpaper), but subsequent session restarts and reboots go directly to a new image from the slideshow (not the previous one, maybe that is a required feature?). (In reply to Oded Arbel from comment #3) > Can't repro with current Neon unstable (Plasma 5.26.80, Frameworks 5.100.0). > On the first reboot, after today's update, it showed the default Plasma > wallpaper before fading into the slideshow (that does not include the Plasma > wallpaper), but subsequent session restarts and reboots go directly to a new > image from the slideshow (not the previous one, maybe that is a required > feature?). Is the new image from the slideshow you mentioned, the same every time i.e., the first wallpaper from the slideshow list? The original behaviour was that the current wallpaper will persist across reboots and will change to the next wallpaper, as per the defined time interval. Right now the wallpaper resets to the first one in the list after every reboot, which means that we will be seeing the same set of wallpapers all the time, even with the slideshow. Many wallpapers further down the list won't be appearing at all, unless we change the Slideshow order manually or set it to Random. I tend to mark the bug as intentional because it's expected that the wallpaper will be reset after plasmashell is restarted, but patches are welcome if someone wants to fix it. (In reply to shscs911 from comment #4) > Is the new image from the slideshow you mentioned, the same every time i.e., > the first wallpaper from the slideshow list? Huh. I think I understand the confusion: I have my sideshow set to random order, but from the discussion I now understand you have it setup to sequential ordering. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2314 Git commit a83fb104e77d0f31f3aa7501e287f5004a4432d2 by Fushan Wen. Committed on 16/11/2022 at 00:13. Pushed by fusionfuture into branch 'master'. wallpapers/image: save last wallpaper in slideshow mode This restores the behavior in 5.25 and before. The config property map is passed to the backend plugin to avoid binding loop warnings caused by updating the "Image" property. FIXED-IN: 5.26.4 M +8 -0 wallpapers/image/imagepackage/contents/ui/main.qml M +35 -1 wallpapers/image/plugin/imagebackend.cpp M +14 -0 wallpapers/image/plugin/imagebackend.h https://invent.kde.org/plasma/plasma-workspace/commit/a83fb104e77d0f31f3aa7501e287f5004a4432d2 Git commit 51fdcd20a50712d6f5c4a88cbc02f167b3718528 by Fushan Wen. Committed on 16/11/2022 at 00:50. Pushed by fusionfuture into branch 'Plasma/5.26'. wallpapers/image: save last wallpaper in slideshow mode This restores the behavior in 5.25 and before. The config property map is passed to the backend plugin to avoid binding loop warnings caused by updating the "Image" property. FIXED-IN: 5.26.4 (cherry picked from commit a83fb104e77d0f31f3aa7501e287f5004a4432d2) M +8 -0 wallpapers/image/imagepackage/contents/ui/main.qml M +35 -1 wallpapers/image/plugin/imagebackend.cpp M +14 -0 wallpapers/image/plugin/imagebackend.h https://invent.kde.org/plasma/plasma-workspace/commit/51fdcd20a50712d6f5c4a88cbc02f167b3718528 (In reply to Fushan Wen from comment #9) > Git commit 51fdcd20a50712d6f5c4a88cbc02f167b3718528 by Fushan Wen. > Committed on 16/11/2022 at 00:50. > Pushed by fusionfuture into branch 'Plasma/5.26'. > > wallpapers/image: save last wallpaper in slideshow mode > > This restores the behavior in 5.25 and before. > > The config property map is passed to the backend plugin to avoid binding > loop warnings caused by updating the "Image" property. > FIXED-IN: 5.26.4 > > > (cherry picked from commit a83fb104e77d0f31f3aa7501e287f5004a4432d2) > > M +8 -0 wallpapers/image/imagepackage/contents/ui/main.qml > M +35 -1 wallpapers/image/plugin/imagebackend.cpp > M +14 -0 wallpapers/image/plugin/imagebackend.h > > https://invent.kde.org/plasma/plasma-workspace/commit/ > 51fdcd20a50712d6f5c4a88cbc02f167b3718528 Thank you so much for fixing this. |