| Summary: | Add the option to search on the default browser what the user typed if krunner does not have any result | ||
|---|---|---|---|
| Product: | [Plasma] krunner | Reporter: | Etienne <etienne.coriou> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | alexander.lohnau, natalie_clarius, nate |
| Priority: | NOR | ||
| Version First Reported In: | 5.26.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/9cc4255347ed021f4bf30088c34570e4bf71735f | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Etienne
2022-11-04 14:01:30 UTC
It really depends on what you were searching for. For example if you were searching for a local file that wasn't found, then doing a web search is definitely not going to he helpful, and would leak your personal data. For that reason we couldn't ever make this an automatic behavior; instead if no results are found, we could add a synthetic search result that says, "Search for [search query] on the web". I'm unsure how generically useful this would actually be, though. What do you think, Alexander and Natalie? I think making use of the existing default search engine setting (where is this actually used anyway?) in the web shortcuts runner and adding a "Search <default engine> for <query>" result that matches any query but with low priority would be useful and should be possible to do. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2307 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2311 Git commit 9cc4255347ed021f4bf30088c34570e4bf71735f by Nate Graham, on behalf of Alexander Lohnau. Committed on 30/11/2022 at 15:09. Pushed by ngraham into branch 'master'. runners/webshortcuts: Provide result for default provider if no other results exist By connecting to the queryFinished signal, we know when all other runners are done with matching. After that we can check if there are any matches and if not add a match for the default provider. This way we have the advantage of only showing a result when it is relevant. For example, when we search for apps and get results, the default search engine result would not be needed. M +18 -0 runners/webshortcuts/webshortcutrunner.cpp M +3 -0 runners/webshortcuts/webshortcutrunner.h https://invent.kde.org/plasma/plasma-workspace/commit/9cc4255347ed021f4bf30088c34570e4bf71735f |