Bug 461391

Summary:	Image List report fails to load
Product:	[Applications] tellico	Reporter:	Robby Stephenson <robby>
Component:	general	Assignee:	Robby Stephenson <robby>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	3.4.4
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/office/tellico/commit/9894bf2752d2584fdd4a61b52d0a738ba902dbf1	Version Fixed In:	3.4.5
Sentry Crash Report:

Description Robby Stephenson 2022-11-04 01:18:04 UTC

As reported on the mailing list, the Image List template fails to load
https://mail.kde.org/pipermail/tellico-users/2022-August/001769.html

The report is a somewhat large file for 1000+ entries.

On investigation, seems to be hitting the 2MB limit int he QWebEngineView::setHtml()

Comment 1 Robby Stephenson 2022-11-06 00:59:48 UTC

Git commit 0a2972f61a03283b0db4d37474e5ec3c792a3d7f by Robby Stephenson.
Committed on 06/11/2022 at 00:59.
Pushed by rstephenson into branch '3.4'.

Use a temporary file for large reports to avoid QWebEngine limit

QWebEngine::load is limited to 2MB, which when encoded and otherwise
processed, seems to be as low as 1,200,000 "characters" in a QString.

For large file, write to a temporary file before loading. This does not
take care of any relative links in the HTML, which will need further
work.
FIXED-IN: 3.4.5

M  +4    -0    ChangeLog
M  +20   -2    src/reportdialog.cpp
M  +2    -0    src/reportdialog.h

https://invent.kde.org/office/tellico/commit/0a2972f61a03283b0db4d37474e5ec3c792a3d7f

Comment 2 Robby Stephenson 2022-11-06 01:00:00 UTC

Git commit 9894bf2752d2584fdd4a61b52d0a738ba902dbf1 by Robby Stephenson.
Committed on 06/11/2022 at 00:55.
Pushed by rstephenson into branch 'master'.

Use a temporary file for large reports to avoid QWebEngine limit

QWebEngine::load is limited to 2MB, which when encoded and otherwise
processed, seems to be as low as 1,200,000 "characters" in a QString.

For large file, write to a temporary file before loading. This does not
take care of any relative links in the HTML, which will need further
work.
FIXED-IN: 3.4.5

M  +4    -0    ChangeLog
M  +20   -2    src/reportdialog.cpp
M  +2    -0    src/reportdialog.h

https://invent.kde.org/office/tellico/commit/9894bf2752d2584fdd4a61b52d0a738ba902dbf1

Comment 3 Robby Stephenson 2024-05-16 01:37:34 UTC

Git commit 03c3f37c2e96fdfbfa7b4a0f6b3b21a6931a4b69 by Robby Stephenson.
Committed on 16/05/2024 at 01:37.
Pushed by rstephenson into branch 'master'.

Fix bug with showing long entries

Avoid QWebEngineView limit of 2MB for html content by using
temporary file.
Related: bug 487079
FIXED-IN: 4.0

M  +4    -0    ChangeLog
M  +24   -5    src/entryview.cpp

https://invent.kde.org/office/tellico/-/commit/03c3f37c2e96fdfbfa7b4a0f6b3b21a6931a4b69

Comment 4 Robby Stephenson 2024-05-16 01:41:35 UTC

Git commit e87e20053644ca51c6ae2b2938203d80952e123c by Robby Stephenson.
Committed on 16/05/2024 at 01:41.
Pushed by rstephenson into branch '3.5'.

Fix bug with showing long entries

Avoid QWebEngineView limit of 2MB for html content by using
temporary file.
Related: bug 487079
FIXED-IN: 4.0

M  +4    -0    ChangeLog
M  +24   -5    src/entryview.cpp

https://invent.kde.org/office/tellico/-/commit/e87e20053644ca51c6ae2b2938203d80952e123c