| Summary: | Allow using light wallpaper with dark theme (or vice versa) | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Jacob Kauffmann <jacob> |
| Component: | Image & Slideshow wallpaper plugins | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | kdedev, m.mcnutt, nate, notmart, qydwhotmail |
| Priority: | NOR | ||
| Version First Reported In: | 5.26.2 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/626bc92807d5d1e88c031dd9a8220f7fb8355c91 | Version Fixed/Implemented In: | 6.5.0 |
| Sentry Crash Report: | |||
|
Description
Jacob Kauffmann
2022-10-31 17:32:57 UTC
Need someone else to implement it as I don't feel it very necessary., and the wallpaper config dialog is already crowded. *** Bug 483966 has been marked as a duplicate of this bug. *** I can see this being an accessibility concern Why does the preview show the non-accessible wallpapers at all if there's no option to use them? E.g. if I'm using the dark theme, and I'm not allowed to select the light wallpapers via the preferences interface, then I don't understand why I'm not just shown the dark version of the previews instead of getting a half-and-half. Removing the light side of the previews is *not* what I actually want here, but it's inconsistent. There is an option to use them; you just have to use an appropriately light or dark color scheme. The fact that this may be undesirable because you might want to use the dark version with a light color scheme or vice versa, is why this feature request is open and marked CONFIRMED. As for why it shows both in the preview, it's to communicate that the wallpaper has light and dark versions. Otherwise you might not know. In progress with https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5705! Git commit 626bc92807d5d1e88c031dd9a8220f7fb8355c91 by Nate Graham, on behalf of David Redondo. Committed on 01/08/2025 at 15:06. Pushed by davidre into branch 'master'. wallpapers/image: Make it possible to manually select light or dark variant Sometimes you like the dark or light variant more than the other. Currently you are forced to either change your theme, or configure some nonsensical sun times (which has other effects) or just live with the wallpaper you dont like as much. FIXED-IN: 6.5 M +34 -17 wallpapers/image/imagepackage/contents/ui/config.qml M +1 -0 wallpapers/image/plugin/CMakeLists.txt M +2 -0 wallpapers/image/plugin/imageplugin.cpp A +19 -0 wallpapers/image/plugin/utils/dynamicmode.h [License: GPL(v2.0+)] M +4 -1 wallpapers/image/plugin/utils/mediaproxy.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/626bc92807d5d1e88c031dd9a8220f7fb8355c91 |