Bug 461228

Summary: Face region is removed when people tag is removed via tag panel
Product: [Applications] digikam Reporter: José Oliver-Didier <jose_oliver>
Component: Faces-WorkflowAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version First Reported In: 7.9.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/graphics/digikam/commit/72aaa22b489c0c120de3fcf3c5539924b1a55faf Version Fixed/Implemented In: 8.0.0
Sentry Crash Report:

Description José Oliver-Didier 2022-10-31 03:00:51 UTC 
SUMMARY
***
Face region is removed when people tag is removed via tag panel.
***


STEPS TO REPRODUCE
1.  Scan for faces an image containing faces - face regions with no assigned people tag (names) assigned.
2.  Add a person's name to the face region and save metadata changes to file - people tags and regions should be saved to file.
3.  Go to the tag panel in "Captions" and remove the people tag from the file.

OBSERVED RESULT
- People tag and face region are removed.

EXPECTED RESULT
- People tag should be removed.
- Face region remains but set to "unknown" - as if it has just been scanned for faces (from step 1)


SOFTWARE/OS VERSIONS
Windows 11

ADDITIONAL INFORMATION
- Only thing that remains should be what should be done with the face region which has been written to the file, should it be also removed from the file (only existing in digikam's db as it has been just scanned) or left with no face name associated to it.
Comment 1 Maik Qualmann 2022-10-31 07:52:03 UTC 
Git commit 72aaa22b489c0c120de3fcf3c5539924b1a55faf by Maik Qualmann.
Committed on 31/10/2022 at 07:50.
Pushed by mqualmann into branch 'master'.

fix remove face region when removing person tag
FIXED-IN: 8.0.0

M  +1    -1    NEWS
M  +1    -1    core/libs/database/tags/facetagseditor.cpp
M  +1    -1    core/libs/database/tags/facetagseditor.h
M  +13   -0    core/libs/properties/captions/disjointmetadata.cpp
M  +1    -0    core/libs/properties/captions/disjointmetadata_p.h
M  +1    -1    core/utilities/facemanagement/workers/databasewriter.cpp

https://invent.kde.org/graphics/digikam/commit/72aaa22b489c0c120de3fcf3c5539924b1a55faf