Bug 461166

Summary:	Icons in Plasma theme override icons in the icon theme, leading to a disjointed appearance since most Plasma themes have few icons
Product:	[Frameworks and Libraries] libplasma	Reporter:	blackcrack <blackcrack>
Component:	libplasma	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	me, nate, niccolo.venerandi, notmart
Priority:	NOR
Version:	5.99.0
Target Milestone:	---
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=438191
Latest Commit:		Version Fixed In:	6.0
Sentry Crash Report:
Attachments:	Screenshoot of the desktop

Description blackcrack 2022-10-29 16:41:29 UTC

Created attachment 153300 [details]
Screenshoot of the desktop

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

Hi, i had make a new Icontheme in Pling Krxpltbc (easy search for "blacky")
and i have notized to change not the Icon on the Clipboardappled org.kde.plasma.clipboard..
i have edit the DelegateToolButtons.qml and have see to be use the edit-delete button..
later have i test if by the others themes also not change.. it has not change, it let show only 
a red symbolic Trash icon and i have a dark background oxyzone, and this is not really to see..
I have also change to Breeze, Oxygen and 2-3 other themes and the edit-delete button had not change..
also with an reboot.. so, i guess, there fits' something not .. because i have write this Bugreport.


STEPS TO REPRODUCE
1. Open systemsettings5
2. go to appearance => icons
3. Add org.kde.plasma.clipboard applet to the desktop
4. copy anything in the clipboard
5.  Change different full Iconthemes with reboot and see the the edit-delete Button.

OBSERVED RESULT
not change of the Button-icon " view-delete" to themed-icon

EXPECTED RESULT
the Delete view-delete icon should change to the actual themed icon
like it does with the other 3 icons as example, view-barcode-qr, document-edit,system-run, this icons change like it should do

SOFTWARE/OS VERSIONS
Windows: ---
macOS: ---
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.6

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2022-11-01 14:33:44 UTC

I can reproduce the issue. When I switch to an icon theme that definitely has its own edit-delete icon, it's not used in the clipboard plasmoid's button row. But the other icons in the row use themed icons properly.

Deleting the plasma and icon caches and restarting plasmashell does not help.

The code for the button is as follows:

PlasmaComponents3.ToolButton {
        id: deleteToolButton
        icon.name: "edit-delete"

        display: PlasmaComponents3.AbstractButton.IconOnly
        text: i18n("Remove from history")

        onClicked: menuItem.remove(UuidRole)

        PlasmaComponents3.ToolTip {
            text: parent.text
        }
    }

So it's not internally using a PlasmaCore.iconItem, which would make it preferentially use the edit-delete icon in the plasma theme. That's not going on here.

Weird issue. Any ideas, Niccolò?

Comment 2 Nate Graham 2022-11-01 14:44:40 UTC

I see the issue. Some icons are getting their styling from the Plasma theme, not the icon theme. If I set the Plasma theme to Oxygen, the edit-delete and configure icons come from the Plasma theme, while the rest of them come from the icon theme.

Needless to say, this is really not ideal at all, and underscores why I don't like that Plasma themes can have icons in them that will override icons from the icon theme.

Comment 3 blackcrack 2022-11-01 15:50:25 UTC

at the systray the same, it should also take the icons from the User determined theme and not only the black/white theme, the coloured Icons at the Systray is mutch more pretty nice as the only colourless black/white icons from plasma.
So please, make it possible to overtake the whole icons from the themes if they are exist in the theme, because therewith determine the user what he/she want. 
(maybe with a checkbox "[ ]Systray Icons from the Theme and not the black/white ones from Plasma" therewith is served both side of Users, under the Icontheme-selector )

best

Comment 4 Nate Graham 2023-08-01 18:12:35 UTC

For Plasma 6, all icons now come from the icon theme; icons in the Plasma style are ignored. This effectively fixes the issue.

See https://invent.kde.org/plasma/plasma-desktop/-/issues/82 for more information.