Bug 460928

Summary: Archive does not export all Effects
Product: [Applications] kdenlive Reporter: Valerio Bozzolan <boz>
Component: Video Display & ExportAssignee: Jean-Baptiste Mardelle <jb>
Status: CONFIRMED ---    
Severity: normal CC: boz, erjiang
Priority: NOR    
Version: 19.12.3   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:

Description Valerio Bozzolan 2022-10-24 09:09:20 UTC
Archiving a project should create a reproducible project, but some effects are not exported.

STEPS TO REPRODUCE
1. create a simple project (e.g. an image for some seconds)
3. apply a random effect (example: transform)
4. save effect (example name: "My Transform")
5. save
6. Project > Archive
7. Try to import that again, on a fresh installation.

OBSERVED RESULT

When re-importing on a fresh installation, any custom effect is lost ("My Transform" effect is lost).

EXPECTED RESULT

When exporting from Archive, any custom effect should be exported as well.
When importing from Archive, any missing custom effect should be imported as well.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:  19.12.3

ADDITIONAL INFORMATION

https://t.me/kdenlive/58281
Comment 1 Valerio Bozzolan 2022-10-24 09:18:00 UTC
Honestly I tried this in 19.12.3 but other people were able to reproduce on Telegram from latest on master.
Comment 2 Valerio Bozzolan 2022-10-24 10:08:22 UTC
You may be interested in the related error message:

> Missing effect: EXAMPLEEFFECT will be removed from project.
Comment 3 erjiang 2022-10-26 03:45:46 UTC
I think this is a general deficiency in custom effects: the custom effect is saved outside the project file. This would also be a problem if you send your project files to a colleague on a different computer.
Comment 4 Valerio Bozzolan 2022-10-26 06:21:42 UTC
With this information, maybe an easy way to do is could be:

- when saving an effect, also save it in the project folder
- when the project is opened: import the effect if missing or, if already present, just ask Y/n «Do you want to import the effect "%s" from the project? This will update your already existing system effect.»