Bug 460797

Summary: mediacontroller cannot render Images that have URL Query Parameters
Product: [Plasma] plasmashell Reporter: hugeblank <hugeblank>
Component: Media Player widgetAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: kde, nate, qydwhotmail
Priority: NOR    
Version: 5.26.1   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description hugeblank 2022-10-21 09:52:25 UTC 
SUMMARY

This is probably an upstream issue with whatever handles image fetching, but the farthest I could bother isolating it was to the mediacontroller plasmoid. The specific issue stems from AlbumArtStack:
```
file:///usr/share/plasma/plasmoids/org.kde.plasma.mediacontroller/contents/ui/AlbumArtStackView.qml:124:13: QML Image: Error decoding: https://i.ytimg.com/vi/dQw4w9WgXcQ/hqdefault.jpg?sqp=-oaymwEcCNACELwBSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLB_p0PncTtkrhaNDZtntrE3gKkoYw: Unsupported image format
```

To attempt to fix this, I found that I could replace line 46 of the same file with:
`"source": root.albumArt.includes("i.ytimg.com/") ? root.albumArt.substring(0, root.albumArt.indexOf('?')) : root.albumArt,`
and it works as it has in the past. The above effectively snips the query parameters if the URL is from youtubes CDN. Not a good solution, but it proves the point that it's the query params that's causing the problem.

STEPS TO REPRODUCE
1. Have a media controller widget on the desktop.
2. Run `killall plasmashell; kstart5 plasmashell`
3. Notice the error produced, and that the fallback icon is used (firefox or chrome logo)

OBSERVED RESULT
The fallback logo is used instead of the image

EXPECTED RESULT
The image provided by the ytimg domain be used

SOFTWARE VERSIONS
(see above fields for general details)
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.6
Comment 1 Fushan Wen 2022-10-21 11:06:03 UTC 
If you can write a simple qml test case, can you report the bug to upstream Qt?
Comment 2 Nate Graham 2022-10-21 17:04:55 UTC 
Fixing it ourselves is also reasonable IMO, since this is a somewhat unusual use case.

But fixing it in Qt would be even better!
Comment 3 hugeblank 2022-10-21 22:25:12 UTC 
(In reply to Fushan Wen from comment #1)
> If you can write a simple qml test case, can you report the bug to upstream Qt?

I *could*, but I'm really not all that confident in my ability to make plasmoids in the first place. I discovered this issue while debugging an already made widget that I was trying to fix, and figured it was the responsible thing to do.
Comment 4 hugeblank 2022-10-21 22:29:51 UTC 
(In reply to Nate Graham from comment #2)
> Fixing it ourselves is also reasonable IMO, since this is a somewhat unusual
> use case.
> 
> But fixing it in Qt would be even better!

I think this potentially is a regression in Qt actually, since I have seen images provided by ytimg in the mediacontroller some time ago. I say potentially because in the past I'm not sure if YT included query parameters in their icon URLs, so this could be a new discovery as a result of YT changing their backend.
Comment 5 Fushan Wen 2022-12-19 16:56:46 UTC 
Cannot reproduce now. Can you still reproduce it?
Comment 6 Fushan Wen 2024-03-14 14:31:11 UTC 
Assuming it's fixed in Plasma 6 because I cannot reproduce it