Bug 460741

Summary:	8c72d54596afe8e97c7bb96cccb324f24f67b7b0 in plasma-integration broke `kioclient appmenu`
Product:	[Plasma] plasma-integration	Reporter:	bluescreenavenger
Component:	general	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sitter
Priority:	NOR
Version First Reported In:	master
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-integration/commit/1ca959de772e949ca8ab55ed41827ea796be1da8	Version Fixed In:	5.27.3
Sentry Crash Report:

Description bluescreenavenger 2022-10-20 04:16:15 UTC

SUMMARY
***
kioclient appmenu
uses the kopenwith dialog as an application launcher, I got it merged in late 2020

Setting QT_QPA_PLATFORMTHEME=KDE to make KDE applications follow the configured KDE theme outside of KDE is also done

With 8c72d54596afe8e97c7bb96cccb324f24f67b7b0 now, it seems that this keeps trying to invoke the portal, and I think it's getting confused because there's no file or something. (because the command also doesn't work under full Plasma)

It's most usable under say something like Weston, or maybe even Wayfire where not a full instance of Plasma will be running, but where an application launcher is needed.
***


STEPS TO REPRODUCE
1. set `QT_QPA_PLATFORMTHEME=KDE` under Weston
2. try to run `kioclient appmenu`

OBSERVED RESULT
Realize it tries to invoke the portal opener, instead of the kopenwith dialog

EXPECTED RESULT
the kopenwith-like dialog should appear

Unsetting QT_QPA_PLATFORMTHEME works, but the KDE applications don't follow the theme

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kernel 5.19
(available in About System)
KDE Plasma Version: 5.26.80
KDE Frameworks Version: 5.100
Qt Version: 5.15

ADDITIONAL INFORMATION

Comment 1 Harald Sitter 2022-10-20 09:31:17 UTC

plasma-integration is meant to be used inside a full plasma session, not something else

Comment 2 bluescreenavenger 2022-10-20 23:03:59 UTC

OK, doing more research and I'll use qt5ct to be able to make the theme look like KDE outside of KDE instead, and it seems like that will work

Comment 3 Harald Sitter 2022-10-21 09:25:09 UTC

Sounds reasonable. FWIW this will also be solved once we reshuffle the code a bit

Comment 4 Bug Janitor Service 2023-02-28 15:54:54 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-integration/-/merge_requests/73

Comment 5 Nate Graham 2023-02-28 18:00:18 UTC

Git commit 1ca959de772e949ca8ab55ed41827ea796be1da8 by Nate Graham.
Committed on 28/02/2023 at 15:53.
Pushed by ngraham into branch 'Plasma/5.27'.

Revert "extend kio with portal-based open-with implementation"

This reverts commit 8c72d54596afe8e97c7bb96cccb324f24f67b7b0.
This reverts commit ae36cf167089b0bf42c29d501e9009b51980b4ec.

This work to unify on a single "Open With" dialog implementation is
important for the long-term, but it's not ready to be rolled out yet
due to missing features in the portal-based dialog that some users
currently rely on ("open with arbitrary binary" and "launch the chosen
app in a terminal window"). Because the roll-out happened for Plasma
5.27 LTS, the possibility of adding those features soon is unlikely
because the next Plasma feature release is 6.0 which is 8+ months way.

Let's revert this work for now to un-break users and stabilize the last
Plasma 5 LTS version, and then we can work on adding the missing
features for Plasma 6.0 and try again then.
Related: bug 460985
FIXED-IN: 5.27.3

M  +1    -7    CMakeLists.txt
M  +0    -1    autotests/CMakeLists.txt
M  +0    -2    src/platformtheme/CMakeLists.txt
M  +0    -203  src/platformtheme/kdeplatformtheme.cpp

https://invent.kde.org/plasma/plasma-integration/commit/1ca959de772e949ca8ab55ed41827ea796be1da8