Bug 460739

Summary:	Network error when starting a new search before last search has finished
Product:	[Frameworks and Libraries] frameworks-knewstuff	Reporter:	Justin Zobel <justin.zobel>
Component:	general	Assignee:	Dan Leinir Turthra Jensen <admin>
Status:	CONFIRMED ---
Severity:	normal	CC:	aleixpol, alexander.lohnau, kdelibs-bugs-null, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Justin Zobel 2022-10-20 00:48:10 UTC

SUMMARY
When using knewstuff-dialogs if you start a new search before the current search is finished you interrupt the network stream and you get incomplete data. This causes an error on the knewstuff-dialog UI.

STEPS TO REPRODUCE
1. Start a new search in plasma styles for example, but type each new letter directly after the search is started (you can see the search start when debugging is enabled in konsole.

OBSERVED RESULT
Unknown Open Collaboration Service API error. (0)

EXPECTED RESULT
No Error

Git Master everything.

This has a few avenues for fixes.

- Don't search automatically when the user types, have a button to begin the search.
- Disable search button/input when a search has begun, enable it once search results returned.

Comment 1 Nate Graham 2022-10-20 16:21:13 UTC

Can reproduce.

I would be in favor of disabling the auto-search feature as it never really worked the way we wanted and caused issues. Discover faced the same problem and it led to us disabling it there too.

But that's not a complete fix, since people could manually initiate a new search while the current one was still running.