| Summary: | Canceling a wallpaper change does not revert to the original image when the current wallpaper is the default one | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Bernhard <micraft.b> |
| Component: | Image & Slideshow wallpaper plugins | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, notmart, qydwhotmail |
| Priority: | NOR | Keywords: | junior-jobs |
| Version First Reported In: | 5.26.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/c15596dbc8e3d90de6f64a8e6545b482ff694579 | Version Fixed/Implemented In: | 5.26.2 |
| Sentry Crash Report: | |||
| Attachments: | relevant section of plasmashell log | ||
|
Description
Bernhard
2022-10-19 02:29:32 UTC
Can you provide log of plasmashell when changing the wallpaper? Created attachment 153020 [details]
relevant section of plasmashell log
Obtained from "journalctl /usr/bin/plasmashell -f". Please let me know if you need something else
Can reproduce A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2238 Git commit 0eb8db0e70330bffc3abfb6c51859e6ab1a3cb70 by Fushan Wen. Committed on 23/10/2022 at 00:38. Pushed by fusionfuture into branch 'master'. wallpapers/image: fall back to default wallpaper when url is empty It's expected to use the default wallpapaer when url is empty, which is also the default value. When closing the wallpaper config dialog without saving config, the source property of MediaProxy will become empty if the previous wallpaper is the default wallpaper, but in setSource empty url will be directly rejected instead of switching to the default wallpaper. This fixes the wrong behavior by calling `useSingleImageDefaults` when url is empty, and reset the source url in `useSingleImageDefaults` so it can find a wallpaper from the current Plasma theme. M +5 -2 wallpapers/image/plugin/utils/mediaproxy.cpp https://invent.kde.org/plasma/plasma-workspace/commit/0eb8db0e70330bffc3abfb6c51859e6ab1a3cb70 Git commit c15596dbc8e3d90de6f64a8e6545b482ff694579 by Fushan Wen. Committed on 23/10/2022 at 01:23. Pushed by fusionfuture into branch 'Plasma/5.26'. wallpapers/image: fall back to default wallpaper when url is empty It's expected to use the default wallpapaer when url is empty, which is also the default value. When closing the wallpaper config dialog without saving config, the source property of MediaProxy will become empty if the previous wallpaper is the default wallpaper, but in setSource empty url will be directly rejected instead of switching to the default wallpaper. This fixes the wrong behavior by calling `useSingleImageDefaults` when url is empty, and reset the source url in `useSingleImageDefaults` so it can find a wallpaper from the current Plasma theme. (cherry picked from commit 0eb8db0e70330bffc3abfb6c51859e6ab1a3cb70) M +5 -2 wallpapers/image/plugin/utils/mediaproxy.cpp https://invent.kde.org/plasma/plasma-workspace/commit/c15596dbc8e3d90de6f64a8e6545b482ff694579 |