Summary: | Maximized Qt applications' close buttons don't extend to corner completely | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Kody <kodyvonbargen> |
Component: | wayland-generic | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ahiemstra, kde, kde, nate, notmart, xaver.hugl |
Priority: | VHI | Keywords: | regression |
Version: | 5.26.1 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/kwin/commit/d78187005432ed02159963fd76554678a9db2e67 | Version Fixed In: | 5.26.3 |
Description
Kody
2022-10-18 22:04:20 UTC
This has been happening to me a lot as well, I'm using Plasma Wayland with Breeze Light (from the Breeze Twilight global global theme), same button locations, same graphics card manufacturer. KDE Plasma 5.26.1 KDE Frameworks 5.99 Qt 5.15.6 Linux 6.0.2 Video: https://www.youtube.com/watch?v=5lbshX0gklQ Can reproduce with 200% scale too, also on Wayland. Probably fallout from the floating-point positioning work in 5.26 that's a precursor for proper fractional scaling support. This inconsistently breaks Fitts' Law for all screen edges (not just the close button) and is quite annoying. possibly related/same bug as https://bugs.kde.org/show_bug.cgi?id=459373 ? It happens at 100% scale and with native Wayland applications, so it should be unrelated. Looking closely at the cursor when I push it to the right border, it moves back and forth a little. PointerInputRedirection lets the cursor move until 1919.99999 on my 1080p screen, and then moves it back to 1919.0, effectively moving it in and out of the screen. Git commit 6ef2cdc332f40eb110d7918cadae8985c384ee7c by Arjen Hiemstra. Committed on 25/10/2022 at 08:44. Pushed by ahiemstra into branch 'master'. Window: Floor rather than round when doing hitTest for the decoration Otherwise we may end up with coordinates that are outside the decoration and inadvertantly failing the hittest. M +1 -1 src/window.cpp https://invent.kde.org/plasma/kwin/commit/6ef2cdc332f40eb110d7918cadae8985c384ee7c Git commit d78187005432ed02159963fd76554678a9db2e67 by Arjen Hiemstra. Committed on 25/10/2022 at 09:59. Pushed by ahiemstra into branch 'Plasma/5.26'. Window: Floor rather than round when doing hitTest for the decoration Otherwise we may end up with coordinates that are outside the decoration and inadvertantly failing the hittest. (cherry picked from commit 6ef2cdc332f40eb110d7918cadae8985c384ee7c) M +1 -1 src/window.cpp https://invent.kde.org/plasma/kwin/commit/d78187005432ed02159963fd76554678a9db2e67 (In reply to Arjen Hiemstra from comment #5) > Git commit 6ef2cdc332f40eb110d7918cadae8985c384ee7c by Arjen Hiemstra. > Committed on 25/10/2022 at 08:44. > Pushed by ahiemstra into branch 'master'. > > Window: Floor rather than round when doing hitTest for the decoration > > Otherwise we may end up with coordinates that are outside the decoration > and inadvertantly failing the hittest. > > M +1 -1 src/window.cpp > > https://invent.kde.org/plasma/kwin/commit/ > 6ef2cdc332f40eb110d7918cadae8985c384ee7c Thank you for taking the time to hunt down the bug and fix it. I'm glad it was a simple fix |