Summary: | disInstr(arm64): unhandled instruction 0x4E819402 (dotprod/ASIMDDP) | ||
---|---|---|---|
Product: | [Developer tools] valgrind | Reporter: | edeturk32 |
Component: | memcheck | Assignee: | Julian Seward <jseward> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | joost.vandevondele, mark, wash |
Priority: | NOR | ||
Version: | 3.20 GIT | ||
Target Milestone: | --- | ||
Platform: | RedHat Enterprise Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
archive containing sdot.c and valgrind output
Patch to add FEAT_DotProd support Patch to add FEAT_DotProd support |
Description
edeturk32
2022-10-17 18:26:38 UTC
Created attachment 160568 [details]
Patch to add FEAT_DotProd support
I have implemented support for the dot product instructions (more specifically those under the FEAT_DotProd feature). The attached patch file applies cleanly to 'master' as of this writing. I haven't yet figured out the 'correct' process for submitting changes to the valgrind project.
On Friday I submitted the change to the valgrind-developers mailing list, https://sourceforge.net/p/valgrind/mailman/valgrind-developers/thread/ED40273D-295D-445C-8D97-9FC48F535932@amazon.com/ Created attachment 160669 [details]
Patch to add FEAT_DotProd support
Found a cfarm machine that supports ASIMDDP. This was a really good patch. Thanks. Only added a NEWS entry, then pushed as: commit f42b9a434e12bc14ec821183a69b86e91da0577c Author: William Ashley <wash@amazon.com> Date: Fri Nov 10 17:51:12 2023 +0100 Bug 460616 - Add support for aarch64 dotprod instructions This change adds support for the FEAT_DotProd instructions SDOT <Vd>.<Ta>, <Vn>.<Tb>, <Vm>.4B[<index>] SDOT <Vd>.<Ta>, <Vn>.<Tb>, <Vm>.<Tb> UDOT <Vd>.<Ta>, <Vn>.<Tb>, <Vm>.4B[<index>] UDOT <Vd>.<Ta>, <Vn>.<Tb>, <Vm>.<Tb> Thanks Mark! *** Bug 484742 has been marked as a duplicate of this bug. *** |