Bug 460596

Summary: dsControlFlow support for CMake is missing.
Product: [Frameworks and Libraries] frameworks-syntax-highlighting Reporter: Lukas Sommer <sommerluk>
Component: syntaxAssignee: KWrite Developers <kwrite-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: jonathan.poelen, walter.von.entferndt
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/frameworks/syntax-highlighting/commit/b067d6098da740c26aff54306b549cc79a297c60 Version Fixed In:
Sentry Crash Report:

Description Lukas Sommer 2022-10-17 14:41:27 UTC 
dsControlFlow support for CMake is missing.

OBSERVED RESULT

The following statements

break
continue
elseif
else
endforeach
endif
endwhile
foreach
if
while

are highlighted in the style dsKeyword. 


EXPECTED RESULT


The following statements

break
continue
elseif
else
endforeach
endif
endwhile
foreach
if
while

are highlighted in the style dsControlFlow.
Comment 1 Jonathan Poelen 2022-10-18 00:29:40 UTC 
You can add `FEATURE: 460596`¹ in your commit message so that the associated number is automatically closed when the MR is merged.

¹ https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
Comment 2 Jonathan Poelen 2022-10-18 00:31:57 UTC 
Oops, wrong issue. To make amends, I'll watch this.
Comment 3 Bug Janitor Service 2022-10-18 01:09:19 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/376
Comment 4 Christoph Cullmann 2022-10-26 09:01:03 UTC 
Git commit b067d6098da740c26aff54306b549cc79a297c60 by Christoph Cullmann, on behalf of Jonathan Poelen.
Committed on 26/10/2022 at 09:00.
Pushed by cullmann into branch 'master'.

CMake: add Control Flow style for if, else, while, etc

M  +3    -3    autotests/html/highlight.cmake.dark.html
M  +3    -3    autotests/reference/highlight.cmake.ref
M  +2    -1    data/generators/cmake.xml.tpl
M  +1    -1    data/generators/cmake.yaml
M  +15   -1    data/generators/generate-cmake-syntax.py
M  +11   -10   data/syntax/cmake.xml

https://invent.kde.org/frameworks/syntax-highlighting/commit/b067d6098da740c26aff54306b549cc79a297c60