Bug 460568

Summary: Star rating not saved
Product: [Applications] digikam Reporter: _ <myaccount132>
Component: Tags-RatingAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 7.8.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 8.0.0
Sentry Crash Report:

Description _ 2022-10-17 06:22:05 UTC
If you try to give star rating and captions same time, stars will not be saved.

i) select image
ii) click desired caption at sidebar
iii) click desired star rating at image
iv) select another image
v) previously selected image caption (ii) gets saved but star rating (iii) disapears

Persisting bug among versions at least up to 7.8.0.
Comment 1 caulier.gilles 2022-10-17 06:29:35 UTC
Did you use AppImage bundle ?

Gilles Caulier
Comment 2 caulier.gilles 2022-10-17 06:30:38 UTC
Also what's the metadata settings about rating ? Look in Setup dialog, Metadata section for details.

Gilles Caulier
Comment 3 Maik Qualmann 2022-10-17 06:33:14 UTC
If you make changes in the Description sidebar on the right, the rating must also be changed there. Changing the rating in the image between is not captured by the right sidebar because the metadata is cached at that moment.

Maik
Comment 4 _ 2022-10-17 06:51:22 UTC
(In reply to Maik Qualmann from comment #3)
> If you make changes in the Description sidebar on the right, the rating must
> also be changed there. Changing the rating in the image between is not
> captured by the right sidebar because the metadata is cached at that moment.

Frankly, I can't even find where to change stars at right sidebar, but it's not practical to keep workflow that difficult. If two things can be made same time in separate sections and keep them in same view, they need to be both cached and applied.
Comment 5 Maik Qualmann 2022-10-17 07:18:23 UTC
Changing the rating or color label is on the same tab as changing the title or caption.

Maik
Comment 6 _ 2022-10-17 13:20:36 UTC
(In reply to Maik Qualmann from comment #5)
> Changing the rating or color label is on the same tab as changing the title
> or caption.

Thanks, but it still adds to workflow if you have plenty of pictures to tag/rate and there's increased possibility of lost data, which I think I've likely lost many times and many beginners do.

Same applies if I press caption and use ctrl+Number. 

When choosing rating first and caption last, all goes as intended, but doesn't work opposite way. While in code that may make difference it shouldn't be for user. There's simply no reason for this behavior. All changes made to selected item should be "cached" wherever these changes are made not depending of order, and all should be saved what is added to display. If such behavior is too difficult to implement UI shouldn't in first place behave as if it's accepting all different things added, and then just reject saving some of them without clear notice.
Comment 7 Maik Qualmann 2022-10-17 18:23:23 UTC
Git commit 595756306b3e5f2aea315dfd396045d79d6da576 by Maik Qualmann.
Committed on 17/10/2022 at 18:22.
Pushed by mqualmann into branch 'master'.

add special case to the description tab
Capture changes of color- and pick label
or rating outside of the description tab.
FIXED-IN: 8.0.0

M  +6    -1    NEWS
M  +21   -0    core/libs/properties/captions/disjointmetadata.cpp
M  +8    -0    core/libs/properties/captions/disjointmetadata.h
M  +5    -1    core/libs/properties/captions/itemdescedittab.h
M  +22   -4    core/libs/properties/captions/itemdescedittab_descview.cpp
M  +44   -2    core/libs/properties/itempropertiessidebardb.cpp

https://invent.kde.org/graphics/digikam/commit/595756306b3e5f2aea315dfd396045d79d6da576