| Summary: | Selection content deleted after transform but remains on screen until canvas area is "refreshed" | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | ecen.cronzeton |
| Component: | Tools/Transform | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73 |
| Priority: | NOR | ||
| Version First Reported In: | 5.0.2 | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/825fa9d2b04847cfa5dffcc8600ff02c665d4f1b | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Krita System Information for Kubuntu
Krita Usage Log for the session recorded in video DebugView log of replicating the bug on git be1bfa4 |
||
|
Description
ecen.cronzeton
2022-10-16 21:05:47 UTC
Created attachment 152914 [details]
Krita Usage Log for the session recorded in video
Hi, Ecen! Could you please test this package if the problem is reproducible with it? https://disk.yandex.ru/d/zPC8Mv85r2tJyQ Please also run DebugView alongside Krita to make sure the catch extra debugging this package dumps. Hi Dmitry, Before using the package I wanted to verify that I was still getting the bug, and I found out what is causing it: I have always had my Freehand Selection Tool bound to V. But the bug only happens if I use that hotkey in step 5. Without a hotkey, OR by rebinding the tool to N, the bug does not happen. I also noticed that even when V is bound to the tool, while V is being held down, some function of the Line Tool is selected and my bound hotkey only applies when V is released. It seems to be this rapid switching to the Line Tool that causes this issue by somehow deleting the selected content without updating the canvas. Knowing this, I can just use a different hotkey, and thus this is no longer an issue for me. It is still a bug, but I'm happy to let you close or downgrade this as you wish. I'm unsure of how to use the package you linked (install as a krita resource?), but hopefully this should no longer be needed, though please tell me if it is. Hi, Ecen! The bug is still valid. I linked a prebuilt Windows package (you said you tested on it :) ). You need to just unpack the zip archive and run Krita from it. About the shortcuts: yes, 'V' is the shortcut that temporarily enables line tool. You can disable that in Preferences->Canvas Input Actions->Tool Invocation. I do wonder if this bug is actually related to the line tool bug I fixed a bit earlier. Perhaps you could also test these stable packages? (with the old configuration of your shortcuts) Windows: https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/ Linux: https://binary-factory.kde.org/job/Krita_Stable_Appimage_Build/ I guess you should first test with one of these packages, and if you can still reproduce the bug, then test the package I linked above (on Windows): https://disk.yandex.ru/d/zPC8Mv85r2tJyQ The bug is reproducible on the stable package (tested the Linux one) and on the first one you linked. I'm attaching the debug view log of starting the first package you linked and replicating the bug. (There was some issue creating a new file, but I just pressed ignore a few times and it went away.) Created attachment 153505 [details]
DebugView log of replicating the bug on git be1bfa4
Hi, Ecen! Thank you for your info! Thanks to that I've managed to reproduce the problem and I have a potential fix. Could you please test a Windows package below? It should have the bug fixed. https://disk.yandex.ru/d/2Je40u-Z5ySkrQ Git commit 01b342fc07c1a8bcaa210c81b194e2a34020b299 by Dmitry Kazakov. Committed on 09/11/2022 at 11:32. Pushed by dkazakov into branch 'master'. Fix image data loss in when the transform tool action is applied to quickly It may happen when the tool is quickly switched to and from by V shortcut assigned to the Brush Tool. Related: bug 461109 M +11 -0 plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/01b342fc07c1a8bcaa210c81b194e2a34020b299 Git commit 825fa9d2b04847cfa5dffcc8600ff02c665d4f1b by Dmitry Kazakov. Committed on 09/11/2022 at 11:38. Pushed by dkazakov into branch 'krita/5.1'. Fix image data loss in when the transform tool action is applied to quickly It may happen when the tool is quickly switched to and from by V shortcut assigned to the Brush Tool. Related: bug 461109 M +11 -0 plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/825fa9d2b04847cfa5dffcc8600ff02c665d4f1b I can confirm that the bug does not happen in the package you sent. Thank you very much and for your hard work on Krita! It's such an awesome application :) |