Summary: | Window appears before animation plays | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | code |
Component: | effects-window-management | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, nate, sebastiankuzlak |
Priority: | NOR | Keywords: | regression |
Version: | git-stable-Plasma/5.26 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/kwin/commit/8599deba2eedab7181339c2555334c7dbab9a2ba | Version Fixed In: | 5.26.1 |
Attachments: | video of the issue |
Description
code
2022-10-12 06:31:59 UTC
confirm A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/3040 Git commit 36440a9d91915a8885a8bbcc1b2dcf39428f07ed by David Edmundson. Committed on 12/10/2022 at 11:28. Pushed by davidedmundson into branch 'master'. Fix scripted shader effect animations AnimationEffect inherits from CrossfadeEffect as it may do a crossfade, but it also has to perform non-crossfading activities with a custom shader. For crossfades we want to draw the old and new window, but this isn't needed where the crossFadeProgress remains at 0. M +1 -1 src/libkwineffects/kwineffects.cpp M +10 -5 src/libkwineffects/kwinoffscreeneffect.cpp https://invent.kde.org/plasma/kwin/commit/36440a9d91915a8885a8bbcc1b2dcf39428f07ed Sorry about breaking your effects. Fortunately it will be fixed in 5.26.1 which will be out within a week In fact, I have to apologize for not reporting this earlier, as it was reported to me already more than two weeks ago... Anyways, thank you for the extremely fast fix! Git commit 8599deba2eedab7181339c2555334c7dbab9a2ba by Nate Graham, on behalf of David Edmundson. Committed on 12/10/2022 at 17:36. Pushed by ngraham into branch 'Plasma/5.26'. Fix scripted shader effect animations AnimationEffect inherits from CrossfadeEffect as it may do a crossfade, but it also has to perform non-crossfading activities with a custom shader. For crossfades we want to draw the old and new window, but this isn't needed where the crossFadeProgress remains at 0. (cherry picked from commit 36440a9d91915a8885a8bbcc1b2dcf39428f07ed) M +1 -1 src/libkwineffects/kwineffects.cpp M +10 -5 src/libkwineffects/kwinoffscreeneffect.cpp https://invent.kde.org/plasma/kwin/commit/8599deba2eedab7181339c2555334c7dbab9a2ba Created attachment 153118 [details]
video of the issue
(In reply to Sebastian Kuźlak from comment #7) > Created attachment 153118 [details] > video of the issue I think there is a still issue. Different but related to the fix. Sorry, it seems i lost my ability to think correctly. Can't edit or... Nvm. Issue is that animation plays while window contents are empty (seen in the video). Sorry for the spam. Unrelated issue. |