Bug 460186

Summary: Timezone not synced correctly for daylight savings in country without DST
Product: [Applications] korganizer Reporter: Rewarp <rewarp>
Component: timezonesAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 5.21.1   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In: 5.24.1
Attachments: Screenshot showing the incorrect meeting time being displayed, and discrepancy versus the month view.

Description Rewarp 2022-10-10 03:08:57 UTC
Created attachment 152677 [details]
Screenshot showing the incorrect meeting time being displayed, and discrepancy versus the month view.

SUMMARY

I missed a company meeting because Korganizer did not show me the correct time for New Zealand while I am based in Malaysia. Checking my online calendar hosted at Fastmail does however show the correct time. To test that it is a problem with the app and not a service provider, I requested my invitation to the meeting to be resent, and it still shows the incorrect time.

Upon closer observation of what is written versus what is shown in the monthly view however, it seems the time is placed correctly, but not in writing. Please check the attached screenshot to see that in writing, it is the incorrect time that does not account for DST, and the month view that does.


STEPS TO REPRODUCE
1. Receive invitation from country with DST to a country without DST 

OBSERVED RESULT

Time not correctly synced in the written out view. On closer observation, discrepancy can be seen in the month view on the right. 

EXPECTED RESULT

Time to be correctly synced across all calendars. CalDav host (Fastmail in this case) shows the correct time.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Tumbleweed 20221006
(available in About System)
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Comment 1 Bug Janitor Service 2023-08-21 21:12:46 UTC
A possibly relevant merge request was started @ https://invent.kde.org/pim/kcalutils/-/merge_requests/28
Comment 2 Daniel Vrátil 2023-08-25 08:19:02 UTC
Git commit fb00f08d56b65c63541af204a77322a77600f6ee by Daniel Vrátil.
Committed on 24/08/2023 at 18:17.
Pushed by dvratil into branch 'release/23.08'.

IncidenceFormatter: fix start/end dt of recurrent event crossing DST

This fixes a particular case when a recurrent event is created during
DST but a subsequent recurrence occurs after DST ends. The formatter
would still show the start/end time of the occurrence as if the
DST still applied. This is best noticed when system timezone does not
observe DST, but the displayed incidence from a timezone uses DST.

This change replaces a custom (broken) algorithm by the one provided
by KCalendarCore to obtain start/end datetime of an incidence on
a particular date, which is actually correct.
Related: bug 451459
FIXED-IN: 5.24.1

M  +3    -17   src/incidenceformatter.cpp

https://invent.kde.org/pim/kcalutils/-/commit/fb00f08d56b65c63541af204a77322a77600f6ee