| Summary: | When trying to generate makefile, I'm getting errors about not being able to link against KDev::Tests | ||
|---|---|---|---|
| Product: | [Applications] kdevelop | Reporter: | Timothy Hutchins <tgh6407> |
| Component: | Language Support: CSS | Assignee: | kdevelop-bugs-null |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | igorkuo |
| Priority: | NOR | ||
| Version First Reported In: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kdevelop/kdev-css/commit/0f762acc3e4f00990b31a5e1b94c4866ff2c65f7 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Timothy Hutchins
2022-10-06 00:36:36 UTC
Which project are you trying to build? d9162558095a5ee8a6f82591c292e5e599bd7f6c does not refer to a commit in KDevelop repository. (In reply to Igor Kushnir from comment #1) > Which project are you trying to build? > d9162558095a5ee8a6f82591c292e5e599bd7f6c does not refer to a commit in > KDevelop repository. I am trying to build the kdev-css language support addon. (In reply to Timothy Hutchins from comment #2) > (In reply to Igor Kushnir from comment #1) > > Which project are you trying to build? > > d9162558095a5ee8a6f82591c292e5e599bd7f6c does not refer to a commit in > > KDevelop repository. > > I am trying to build the kdev-css language support addon. This is the relevant repository: https://invent.kde.org/kdevelop/kdev-css 1. Doesn't Ubuntu provide a package with KDev::Tests? 2. Have you tried turning off BUILD_TESTING CMake variable in kdev-css? (In reply to Igor Kushnir from comment #4) > 1. Doesn't Ubuntu provide a package with KDev::Tests? > 2. Have you tried turning off BUILD_TESTING CMake variable in kdev-css? 1 > kdevelop provides it, but it has to be compiled from source manually with BUILD_TESTING set to on, in the release builds that get pushed to the repositories that option is set to off. 2 > I did try, and looked in the CMakeLists.txt file and I don't think that the project implements that option. According to kdev-css git history, it always unconditionally depended on KDev::Tests. So either something has changed elsewhere recently, or there is some issue on your system. > 1 > kdevelop provides it, but it has to be compiled from source manually with BUILD_TESTING set to on, in the release builds that get pushed to the repositories that option is set to off. I thought that Ubuntu could provide a separate (split) package with KDev::Tests, but maybe it doesn't. > 2 > I did try, and looked in the CMakeLists.txt file and I don't think that the project implements that option. https://api.kde.org/ecm/module/ECMMarkAsTest.html?highlight=build_testing Did you reconfigure CMake after disabling BUILD_TESTING? (In reply to Igor Kushnir from comment #6) > According to kdev-css git history, it always unconditionally depended on > KDev::Tests. So either something has changed elsewhere recently, or there is > some issue on your system. > > 1 > kdevelop provides it, but it has to be compiled from source manually with BUILD_TESTING set to on, in the release builds that get pushed to the repositories that option is set to off. > I thought that Ubuntu could provide a separate (split) package with If it is, then it must not be well documented, I tried looking and ended up empty handed. > KDev::Tests, but maybe it doesn't. > > 2 > I did try, and looked in the CMakeLists.txt file and I don't think that the project implements that option. > https://api.kde.org/ecm/module/ECMMarkAsTest.html?highlight=build_testing > Did you reconfigure CMake after disabling BUILD_TESTING? Yes, many times, all yealding the same result. If kdev-css depends on it, then I believe I would have to compile KDevelop manual. Would you possibly know what target I would have to build to build KDev::Tests so that I won't have to build the entire thing? I think you are right that something is wrong in kdev-css. See e.g. https://invent.kde.org/kdevelop/kdev-php/-/blob/master/parser/CMakeLists.txt Try to enclose the test code in kdev-css/CMakeLists.txt in the `if (BUILD_TESTING)` block. If it works well, please create a merge request. (In reply to Igor Kushnir from comment #8) > I think you are right that something is wrong in kdev-css. See e.g. > https://invent.kde.org/kdevelop/kdev-php/-/blob/master/parser/CMakeLists.txt > > Try to enclose the test code in kdev-css/CMakeLists.txt in the `if > (BUILD_TESTING)` block. If it works well, please create a merge request. The issue has been resolved and a relevant merge request has been created at https://invent.kde.org/kdevelop/kdev-css/-/merge_requests/2 Git commit 0f762acc3e4f00990b31a5e1b94c4866ff2c65f7 by Igor Kushnir, on behalf of Timothy Hutchins. Committed on 10/10/2022 at 08:37. Pushed by igorkushnir into branch 'master'. Don't build tests if BUILD_TESTING CMake option is off Neither kdevelop package nor any extra split package on Ubuntu contains KDev::Tests library. Now instead of rebuilding the kdevelop package with test support, the users can simply turn the BUILD_TESTING option off while building this plugin. M +53 -51 CMakeLists.txt M +27 -25 parser/CMakeLists.txt https://invent.kde.org/kdevelop/kdev-css/commit/0f762acc3e4f00990b31a5e1b94c4866ff2c65f7 |