Bug 460009

Summary:	kmymoney does not contain holiday dates
Product:	[Applications] kmymoney	Reporter:	Ralf Habacker <ralf.habacker>
Component:	packaging	Assignee:	KMyMoney Devel Mailing List <kmymoney-devel>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	5.1.3
Target Milestone:	---
Platform:	Other
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:	5.2
Sentry Crash Report:
Bug Depends on:
Bug Blocks:	426400
Attachments:	testfile.kmy screenshot with holiday settings

Description Ralf Habacker 2022-10-05 12:25:30 UTC

Phil Richardson reported this bug at https://mail.kde.org/pipermail/kmymoney/2022-September/003991.html

> It doesn't contain any holiday data, so my schedules simply work Monday
> to Friday and can't follow the "move to next working day rule".

STEPS TO REPRODUCE
1. Download portable binary for KMyMoney on Windows from https://download.kde.org/stable/kmymoney/5.1.3/
2. unpack 7z file and run start.bat
3. open the appended file (testfile.kmy)
4. in the left view open "Scheduled transactions"

OBSERVED RESULT
In Germany, October 3 is a public holiday. If the week-end option is MoveAfter, the "next due date" should be October 4, which is not the case. KMyMoney selects October 3. Furthermore, December 26th is a holiday, so if December 25th is selected, the 27th should be displayed, which is not the case, the 26th is displayed.

EXPECTED RESULT
In the cases described, October 4 and December 27 would have to be displayed, respectively. 

SOFTWARE/OS VERSIONS
Windows: 10
KDE Frameworks Version:  5.76.0
Qt Version: 5.12.12

Comment 1 Ralf Habacker 2022-10-05 12:28:40 UTC

Created attachment 152598 [details]
testfile.kmy

Comment 2 Ralf Habacker 2022-10-05 12:37:00 UTC

Created attachment 152599 [details]
screenshot with holiday settings

On the "scheduled transactions" settings page, there is a field for selecting the holiday calendar that does not contain an entry. The indicates that a required component (kholidays) has not been installed.

Comment 3 Ralf Habacker 2022-10-06 08:29:27 UTC

(In reply to Ralf Habacker from comment #2)
>  This indicates that a required component (kholidays) has not been installed.

Fixed by adding this component for building kmymoney.