| Summary: | Launch feedback doesn't stop properly when launching terminal apps | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Nicolas Fella <nicolas.fella> |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | bugseforuns, dmatteo002, equeim, kde, kdedev, nate, zocsfxljsgpmiuaanz |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/01b2cad5051f8cdb016757f6942f7a43d550ee6b | Version Fixed/Implemented In: | Plasma 6.7.0 with Frameworks 6.27 |
| Sentry Crash Report: | |||
|
Description
Nicolas Fella
2022-10-04 19:46:56 UTC
In terms of solutions we could 1. Patch htop et al to have StartupNotify=false 2. Force StartupNotify=false for all terminal apps in KIO::ApplicationLauncherJob 3. Force StartupNotify=false for all terminal apps in KWin Not great solutions since we would lose the bouncing cursor completely 4. Special-case inside kwin that when we know a terminal app is launched we "wait" for Konsole/the default terminal app instead 4 seems nice. *** Bug 520624 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/2245 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/9303 Git commit 9e46cb7165b23f986b28749068efd9360c2649a5 by Méven Car, on behalf of Nicolas Fella. Committed on 30/05/2026 at 09:26. Pushed by meven into branch 'master'. kprocessrunner: For apps running in terminal, use terminal emulator's appId When running an app org.foo.bar that has Terminal=true we request an XDG activation token for org.foo.bar. However the actual resulting window will be org.kde.konsole (or whatever the default terminal is). This mismatch will result in the startup feedback being stuck and eventually timing our. Instead resolve the appId of the terminal and use that to request the token. M +15 -0 src/gui/kprocessrunner.cpp https://invent.kde.org/frameworks/kio/-/commit/9e46cb7165b23f986b28749068efd9360c2649a5 Git commit b57c48b264926a2dbc0524fa6766370e7f4e86be by Vlad Zahorodnii. Committed on 31/05/2026 at 14:56. Pushed by vladz into branch 'master'. Clear startup feedback if a window is activated by the Workspace The xdg-activation token can be saved and checked later if the window is not mapped yet. If the activated window and the activation tokens have matching app ids, it will work as expected. However, if the app ids mismatch, the startup feedback won't be cleared (even though it should be). This change makes the XdgActivationV1Integration monitor new windows and clear startup feedbacks as needed. M +44 -0 autotests/integration/activation_test.cpp A +7 -0 autotests/integration/data/org.kde.big-bad-wolf.desktop A +8 -0 autotests/integration/data/org.kde.grandma.desktop A +7 -0 autotests/integration/data/org.kde.little-red-riding-hood.desktop M +6 -0 src/xdgactivationv1.cpp https://invent.kde.org/plasma/kwin/-/commit/b57c48b264926a2dbc0524fa6766370e7f4e86be Git commit 01b2cad5051f8cdb016757f6942f7a43d550ee6b by Vlad Zahorodnii. Committed on 31/05/2026 at 15:26. Pushed by vladz into branch 'Plasma/6.7'. Clear startup feedback if a window is activated by the Workspace The xdg-activation token can be saved and checked later if the window is not mapped yet. If the activated window and the activation tokens have matching app ids, it will work as expected. However, if the app ids mismatch, the startup feedback won't be cleared (even though it should be). This change makes the XdgActivationV1Integration monitor new windows and clear startup feedbacks as needed. (cherry picked from commit b57c48b264926a2dbc0524fa6766370e7f4e86be) M +44 -0 autotests/integration/activation_test.cpp A +7 -0 autotests/integration/data/org.kde.big-bad-wolf.desktop A +8 -0 autotests/integration/data/org.kde.grandma.desktop A +7 -0 autotests/integration/data/org.kde.little-red-riding-hood.desktop M +6 -0 src/xdgactivationv1.cpp https://invent.kde.org/plasma/kwin/-/commit/01b2cad5051f8cdb016757f6942f7a43d550ee6b Git commit 520255401b5bcfa86ce0c050adfbbba0b8980d15 by Akseli Lahtinen. Committed on 31/05/2026 at 11:33. Pushed by akselmo into branch 'master'. KAboutData: Reload applicationData when desktopFileName param is set When applications are created with KAboutData, the registry is also created, which is where we set up the initial values. Setting the desktopFileName directly to the private class does not work, as it does not update the one in registry that the application uses. This makes sure we reload the desktopFileName for our application when it's being set. M +1 -1 src/lib/kaboutdata.cpp https://invent.kde.org/frameworks/kcoreaddons/-/commit/520255401b5bcfa86ce0c050adfbbba0b8980d15 *** Bug 455265 has been marked as a duplicate of this bug. *** *** Bug 487204 has been marked as a duplicate of this bug. *** |