Summary: | frequently played view not working or unclear on what statistic | ||
---|---|---|---|
Product: | [Applications] Elisa | Reporter: | kde.le2n5 |
Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jackhill3103, nate |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Other | ||
Latest Commit: | https://invent.kde.org/multimedia/elisa/commit/c266d7097f4996920c658a4d8732b2f8e949b926 | Version Fixed In: | 23.04 |
Sentry Crash Report: |
Description
kde.le2n5
2022-10-04 19:32:07 UTC
Seems like the Recently Played and Frequently Played views both display the same (incorrect) track list. The problem is `computePreferredSortRole` setting `sortRole` to `TitleRole` because the list view is based on tracks (i.e. sorting by track title). Workaround for now is to remove the function calls to `computePreferredSortRole` on lines 362 & 364 of viewmanager.cpp. I think these calls exist for future purposes when grid/list views are able to be set by the user (bug 411952). A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/406 Git commit c266d7097f4996920c658a4d8732b2f8e949b926 by Jack Hill. Committed on 11/01/2023 at 17:11. Pushed by ngraham into branch 'master'. Sort the "Frequently Played" view based on the play count of each track Previously was using a formula that prioritised recently played tracks. This meant you could have a track with 8 plays being displayed higher than a track with 10 plays. Now the view only sorts tracked based on the play count of each track. M +1 -12 src/databaseinterface.cpp M +0 -1 src/datatypes.h M +0 -4 src/models/editabletrackmetadatamodel.cpp M +0 -2 src/models/trackmetadatamodel.cpp M +1 -1 src/viewmanager.cpp M +2 -2 src/viewslistdata.cpp https://invent.kde.org/multimedia/elisa/commit/c266d7097f4996920c658a4d8732b2f8e949b926 |