| Summary: | Mark favorites | ||
|---|---|---|---|
| Product: | [Applications] kasts | Reporter: | tobias |
| Component: | general | Assignee: | bart |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/multimedia/kasts/commit/db234722cb7ca0fac7ebacb68ef796de898a3d60 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
tobias
2022-10-01 12:43:53 UTC
I agree: seeing that quite a few other clients also have a "favorite" option, it makes sense to implement it at some point. PS: However, if I interpret your remark correctly, a "favorite" option is actually not your real request? "Favorite" would be used to mark episodes that you already listened to and liked. It looks like you're looking for a "to-do" list or something similar? (In reply to bart from comment #1) > I agree: seeing that quite a few other clients also have a "favorite" > option, it makes sense to implement it at some point. > > PS: However, if I interpret your remark correctly, a "favorite" option is > actually not your real request? "Favorite" would be used to mark episodes > that you already listened to and liked. It looks like you're looking for a > "to-do" list or something similar? While that is technically correct, I would be fine with just one "Favorite" option/category for both scenarios. But it would be good to have a way to only show favorites from one Podcast. Because if you have many podcasts and all the favorites would just be in one big list, it can get messy. Maybe there could be a button in the "Podcast Details" Section that reads "Show Favorites" and then only the favorite Episodes are shown. Or something similar. Just realized, if I disable "Automatically Queue" in the "Queue"-Settings, I can probably already achieve what I want. The Queue then should be like a favorite list, where I can manually add podcast episodes. Still a seperate list would be a good thing I guess. Git commit db234722cb7ca0fac7ebacb68ef796de898a3d60 by Bart De Vries. Committed on 23/03/2023 at 15:45. Pushed by bdevries into branch 'master'. Add implementation for favorites M +12 -0 src/database.cpp M +1 -0 src/database.h M +27 -0 src/datamanager.cpp M +5 -0 src/datamanager.h M +37 -0 src/entry.cpp M +6 -0 src/entry.h M +5 -0 src/feed.cpp M +3 -0 src/feed.h M +1 -0 src/models/abstractepisodemodel.cpp M +1 -0 src/models/abstractepisodemodel.h M +17 -0 src/models/abstractepisodeproxymodel.cpp M +2 -0 src/models/abstractepisodeproxymodel.h M +1 -0 src/models/downloadmodel.cpp M +2 -0 src/models/entriesmodel.cpp M +5 -1 src/models/episodemodel.cpp M +1 -0 src/models/episodemodel.h M +8 -0 src/qml/EntryPage.qml M +8 -1 src/qml/GenericEntryDelegate.qml M +30 -0 src/qml/GenericEntryListView.qml M +3 -1 src/qml/SearchFilterBar.qml M +2 -1 src/updatefeedjob.cpp https://invent.kde.org/multimedia/kasts/commit/db234722cb7ca0fac7ebacb68ef796de898a3d60 Thx for the implementation. I just tested a new build and had to look very closely to find the options. Most of them are quite hidden. Maybe you could add some more (direct) buttons in the future? For example: - "Mark as Favorite" on the Episode Details page - "Favorites" (shows all Favorites) on the Episodes List page - "Favorites" on the Podcast Details page > Thx for the implementation. > I just tested a new build and had to look very closely to find the options. Most of them are quite hidden. > Maybe you could add some more (direct) buttons in the future? > For example: > - "Mark as Favorite" on the Episode Details page The toolbar button is there already. It's in the overflow menu since it's a less essential button than start/pause, stream, download, add/remove to/from queue. Additionally, you can access it directly by right-clicking on any episode. > - "Favorites" (shows all Favorites) on the Episodes List page > - "Favorites" on the Podcast Details page In both cases, you can access it through the search and filter functionality. It doesn't make a lot of sense to add a dedicated button for this, since then there should also be buttons for played, unplayed, new, etc and the whole overflow menu will become overcrowded. > The toolbar button is there already. It's in the overflow menu since it's a > less essential button than start/pause, stream, download, add/remove to/from > queue. > Additionally, you can access it directly by right-clicking on any episode. > In both cases, you can access it through the search and filter > functionality. It doesn't make a lot of sense to add a dedicated button for > this, since then there should also be buttons for played, unplayed, new, etc > and the whole overflow menu will become overcrowded. I understand your concerns, but it is kind of unintuitive this way. Maybe you will like one of the following ideas: 1. Add a category "favorites" to the front page. The category could show both a full list of favorite episodes and additionally maybe a view based on seperate Podcasts (like the Subscriptions page+Favorites only). 2. Offer at least an option in the settings, for 1. and/or the ideas that I described above. |