| Summary: | Cannot go into fullscreen mode | ||
|---|---|---|---|
| Product: | [Applications] Koko | Reporter: | Jack Hill <jackhill3103> |
| Component: | General | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | carl, nate |
| Priority: | NOR | Keywords: | regression |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/koko/commit/20be0503dd2cdc9eef75736099d28d25bbc2490c | Version Fixed In: | |
| Sentry Crash Report: | |||
Seems to have been broken in commit 994ff2145d4c38bfb36d00b6f8edfe128e7f1cd5 when the function saveWindowState was deleted in Main.qml (In reply to Jack Hill from comment #1) > Seems to have been broken in commit 994ff2145d4c38bfb36d00b6f8edfe128e7f1cd5 > when the function saveWindowState was deleted in Main.qml This also broke the slideshow functionality Git commit 20be0503dd2cdc9eef75736099d28d25bbc2490c by Carl Schwan. Committed on 25/01/2023 at 17:53. Pushed by carlschwan into branch 'master'. Fix entering full screen and slideshow mode Signed-off-by: Carl Schwan <carl@carlschwan.eu> M +10 -0 src/controller.cpp M +1 -0 src/controller.h M +6 -3 src/qml/ImageViewPage.qml M +3 -1 src/qml/Main.qml M +2 -1 src/qml/SlideshowManager.qml https://invent.kde.org/graphics/koko/commit/20be0503dd2cdc9eef75736099d28d25bbc2490c |
SUMMARY This is on a git master build from commit 19e4c82aac3aa8b93dbbca9123298e5c38696b58 but it was also occurring when I built from the tag 22.06 or 22.04 (can't remember which) STEPS TO REPRODUCE 1. Open Koko 2. Open a photo 3. Click fullscreen OBSERVED RESULT Nothing happens Terminal output: qrc:/qml/ImageViewPage.qml:158: TypeError: Property 'saveWindowState' of object Main_QMLTYPE_138(0x19eca00) is not a function EXPECTED RESULT Should enter fullscreen mode SOFTWARE/OS VERSIONS Operating System: openSUSE Tumbleweed 20220925 KDE Plasma Version: 5.25.5 KDE Frameworks Version: 5.98.0 Qt Version: 5.15.5 Kernel Version: 5.19.10-1-default (64-bit) ADDITIONAL INFORMATION