Bug 459695

Summary: Digikam does not include Gopro raw images *.GPR
Product: [Applications] digikam Reporter: Kristian Karl <kristian.hermann.karl>
Component: Preview-RAWAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED INTENTIONAL    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 7.9.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 8.1.0
Sentry Crash Report:

Description Kristian Karl 2022-09-26 12:11:41 UTC 
SUMMARY
When I tried to let digikam 7.9.0  scan for GPR images in an album, it does not include them.
I could not see any gopro raw images, *.GPR files

I thought that digikam was able to detect and include those since  new version 0.20 of libraw.
But, maybe not the *.GPR files? 

I tested this using digiKam-7.9.0-20220926T033221-x86-64.appimage on this machine:

Operating System: Ubuntu 22.10
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Kernel Version: 5.19.0-18-generic (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-2600K CPU @ 3.40GHz
Memory: 15,6 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 960/PCIe/SSE2
Comment 1 Maik Qualmann 2022-09-26 13:44:58 UTC 
It is not a problem for us to add the RAW file type *.GPR. If you have a sample for download, I did not find a link on the web quickly.

Maik
Comment 2 Kristian Karl 2022-09-26 14:12:33 UTC 
I uploaded to dropbox an example of a raw Gopro image, GOPR0006.GPR, made by a Gopro Hero 11 camera.
https://www.dropbox.com/s/1fas6ackb5g7uyt/GOPR0006.GPR?dl=0
Comment 3 caulier.gilles 2022-09-26 14:22:02 UTC 
Maik, 

I think it will not be enough to add the type mime. GoPro raw files support need extra code for Libraw : 

Gilles
Comment 5 Maik Qualmann 2022-09-26 16:55:34 UTC 
Gilles is right, Libraw cannot readily open the file.

Maik
Comment 6 caulier.gilles 2023-05-02 08:14:15 UTC 
For the libraw README.GoPro.txt:

I. GPR SDK comes with (patched) Adobe DNG SDK source (v1.4 but outdated).
   This DNG SDK is *NOT* compatible with LibRaw since 0.20 due to
   internals change .

II. So, you need to patch latest Adobe DNG SDK v1.4 (dated 2015), this version
   is available from Adobe:
   http://download.adobe.com/pub/adobe/dng/dng_sdk_1_4.zip
   or use Adobe DNG SDK v1.6   
  
  (most likely, this apply for v1.5 too, but not tested/checked).

digiKam includes libraw in core, not as separated dependency. DNG DSK is include too in digiKam core. It's the last 1.5 version.

In other word, add GPR support will be a puzzle a there is a risk to make digiKam instable with all others RAW files. So i close this file as INTENTIONAL. We can revise later this file if and only if the GPR support will be simplified and safe.

Best regards

Gilles Caulier