Bug 459621

Summary: ToolBarLayout causing logs in CardsGridView without DelegateRecycler
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Matej Starc <matej.starc>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs>
Status: RESOLVED NOT A BUG    
Severity: normal CC: nate, notmart
Priority: NOR    
Version: Master   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: test file
log

Description Matej Starc 2022-09-24 20:51:36 UTC
Created attachment 152390 [details]
test file

SUMMARY
I've been working on a rework of CardsGridView and during testing I noticed that ActionToolLayout and ActionsToolBar are causing logs when scrolling really fast.


STEPS TO REPRODUCE
1. Checkout to ``work/sporknife/CardsGridView_rework``
2. Make it use the newly compiled kirigami framework``source ~/kde/build/kirigami/prefix.sh``
3. Execute the test file I provided.
4. Drag the scrollbar from top to bottom.

OBSERVED RESULT
See attached log.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Kernel Version: 5.19.10-arch1-1 (64-bit)
Graphics Platform: Wayland
Processors: 16 × AMD Ryzen 7 5800H with Radeon Graphics
Memory: 15.0 GiB of RAM
Graphics Processor: AMD RENOIR
Manufacturer: ASUSTeK COMPUTER INC.
Product Name: Zenbook UN5401QAB_UN5401QA
System Version: 1.0
Comment 1 Matej Starc 2022-09-24 20:52:01 UTC
Created attachment 152391 [details]
log
Comment 2 Nate Graham 2022-09-26 19:04:58 UTC
I don't see this issue without your branch applied, so this is going to be caused by your changes there.
Comment 3 Matej Starc 2022-09-26 19:29:38 UTC
(In reply to Nate Graham from comment #2)
> I don't see this issue without your branch applied, so this is going to be
> caused by your changes there.

You can also get the same thing by directly using a card delegate without the DelegateRecycler.
Comment 4 Nate Graham 2022-09-27 14:29:02 UTC
Can you attach a test case that shows the bug with current git master code?
Comment 5 Matej Starc 2022-09-27 15:44:04 UTC
(In reply to Nate Graham from comment #4)
> Can you attach a test case that shows the bug with current git master code?

You cannot replicate this on current master (without changing any kirigami code).
Comment 6 Matej Starc 2022-09-27 15:44:48 UTC
(In reply to Matej Starc from comment #5)
> (In reply to Nate Graham from comment #4)
> > Can you attach a test case that shows the bug with current git master code?
> 
> You cannot replicate this on current master (without changing any kirigami
> code).

Nvm. Scratch that.
Comment 7 Matej Starc 2022-09-27 15:57:09 UTC
(In reply to Nate Graham from comment #4)
> Can you attach a test case that shows the bug with current git master code?

1. Download the test file I provided.
2. Open the test file with qmlscene in the terminal (``qmlscene cardTest.qml``)
3.Make the window wide enough for at least 5 columns of cards to be displayed
4. Pull the scrollbar to the bottom and let go of the scrollbar.

OBSERVED RESULT
ActionToolBar actions are not displayed, while all other card widgets are (even the image).