Bug 459537

Summary:	"Ignored" face regions should not be saved into XMP metadata
Product:	[Applications] digikam	Reporter:	MarcP <iwannaberich>
Component:	Faces-Workflow	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ericmitchell_ca, iwannaberich, metzpinguin
Priority:	NOR
Version:	7.9.0
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/bead8db31957d60c252bcb75d5c6c5df62054bae	Version Fixed In:	8.0.0
Sentry Crash Report:

Description MarcP 2022-09-22 16:16:23 UTC

SUMMARY

Whenever you click to "Ignore" a face, a face region and a keyword with the name "Ignore" is saved into the picture metadata. As if it was a person called "Ignored". When you open one of these pictures, said person will have a rectangle over their face with the word "Ignored".

I believe in this case, that info should only be saved into digikam's database, but not in the metadata, as the only purpose for that function is to hide that face from the suggestions and avoid it being detected again by the face recognition engine.

What do you think?


STEPS TO REPRODUCE
1. Run face detection on some pictures
2. Ignore some pictures
3. Check the metadata on these pictures

OBSERVED RESULT
4. "Ignored" is saved as a face region and as a keyword in XMP metadata

EXPECTED RESULT
Ignored faces are just hidden in the interface under their own category, nothing is written to the image metadata.

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: Kubuntu 22.04 LTS
(available in About System)
KDE Plasma Version: 5.24.6
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.3

Comment 1 Maik Qualmann 2022-09-22 16:48:52 UTC

Yes, that's exactly how it should be, because the metadata standard doesn't know about ignored faces. A quick test shows that an ignored face is not saved either. However, the write database to metadata operation then saves the ignored face to the metadata. i will fix it.

Maik

Comment 2 Maik Qualmann 2022-09-24 15:18:06 UTC

Git commit bead8db31957d60c252bcb75d5c6c5df62054bae by Maik Qualmann.
Committed on 24/09/2022 at 15:16.
Pushed by mqualmann into branch 'master'.

not write system face regions to the metadata
Image Editor better support for face rotation for all face types.
FIXED-IN: 8.0.0

M  +2    -1    NEWS
M  +44   -60   core/libs/fileactionmanager/metadatahub.cpp
M  +0    -11   core/libs/fileactionmanager/metadatahub.h
M  +46   -77   core/utilities/imageeditor/main/imagewindow.cpp
M  +2    -1    core/utilities/imageeditor/main/imagewindow_p.h

https://invent.kde.org/graphics/digikam/commit/bead8db31957d60c252bcb75d5c6c5df62054bae

Comment 3 MarcP 2022-09-24 15:29:00 UTC

Thank you, Maik!

Comment 4 ericmitchell_ca 2023-11-13 00:37:09 UTC

I disagree strongly with this change, and I have submitted https://bugs.kde.org/show_bug.cgi?id=476908 to request that it be reversed, or for it to be optional as to whether the "Ignored" regions are written to file.