Bug 459255

Summary:	BannerImage title aligned to the left, and after that rightfully aligned to the right
Product:	[Frameworks and Libraries] frameworks-kirigami	Reporter:	Matej Starc <matej.starc>
Component:	general	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	notmart
Priority:	NOR
Version First Reported In:	Master
Target Milestone:	Not decided
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/kirigami/commit/2dd8ac0691b7c0a034674794703dd211d818a97a	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	slowed down bug showcase

Description Matej Starc 2022-09-17 07:07:14 UTC

SUMMARY
I've already reported this in the MR that fixed the glitch for lower hz/fps monitors (it just called the implicit width & height calculation after the titleAlignment property changed) and even added a video. 

Here is the MR: https://invent.kde.org/frameworks/kirigami/-/merge_requests/610


STEPS TO REPRODUCE
1. Checkout to origin/master
2. Change the title alignment inside the application

OBSERVED RESULT
The title first gets anchored to the left, and AFTER that gets anchored to the right, which results in a weird visual bug.

EXPECTED RESULT
Should DIRECTLY anchor and not let Qt do its own thing (in this case).

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Kernel Version: 5.19.8-zen1-1-zen (64-bit)
Graphics Platform: Wayland
Processors: 12 × Intel® Core™ i7-8700 CPU @ 3.20GHz
Memory: 15.5 GiB of RAM
Graphics Processor: AMD Radeon RX 480 Graphics

Comment 1 Matej Starc 2022-09-17 07:11:50 UTC

Here is the full video of me showcasing the bug. I only managed a few cases where it is actually seen on the video. I would like to warn that I always get this bug when I change the alignment in BannerImage (it is frequent).

https://cloud.aljaxus.eu/index.php/s/gMbRbTmJyrn4ijw

PS: I can only upload it this way, because the video is too big.

Comment 2 Matej Starc 2022-09-17 07:12:52 UTC

Created attachment 152141 [details]
slowed down bug showcase

Here I show the bug, so it can be seen on every monitor (I can only see the bug in 144hz/fps).

Comment 3 Matej Starc 2022-09-17 07:21:03 UTC

(In reply to Matej Starc from comment #2)
> Created attachment 152141 [details]
> slowed down bug showcase
> 
> Here I show the bug, so it can be seen on every monitor (I can only see the
> bug in 144hz/fps).

It seems it can't be seen in this video as well when I upload it to this website.(In reply to Matej Starc from comment #2)
> Created attachment 152141 [details]
> slowed down bug showcase
> 
> Here I show the bug, so it can be seen on every monitor (I can only see the
> bug in 144hz/fps).

It seems it can't be really seen in this video. I hope it can be seen here.

Comment 4 Matej Starc 2023-12-14 03:26:20 UTC

Git commit 2dd8ac0691b7c0a034674794703dd211d818a97a by Matej Starc.
Committed on 22/04/2023 at 10:32.
Pushed by sporknife into branch 'master'.

BannerImage: fix vertical and horizontal alignment order bug

Because of the order that anchor properties are set, we have to manually specify the order to avoid first anchoring to the opposite side first and then the destination which can be seen on higher Hz monitors.

M  +39   -16   src/controls/private/BannerImage.qml

https://invent.kde.org/frameworks/kirigami/commit/2dd8ac0691b7c0a034674794703dd211d818a97a

Comment 5 Matej Starc 2023-12-14 03:26:21 UTC

Git commit 2dd8ac0691b7c0a034674794703dd211d818a97a by Matej Starc.
Committed on 22/04/2023 at 10:32.
Pushed by sporknife into branch 'master'.

BannerImage: fix vertical and horizontal alignment order bug

Because of the order that anchor properties are set, we have to manually specify the order to avoid first anchoring to the opposite side first and then the destination which can be seen on higher Hz monitors.

M  +39   -16   src/controls/private/BannerImage.qml

https://invent.kde.org/frameworks/kirigami/commit/2dd8ac0691b7c0a034674794703dd211d818a97a