Bug 459244

Summary: "No Windows" label does not show up for "Window class on current desktop" when there are no non-minimized windows
Product: [Plasma] kwin Reporter: ratijas <me>
Component: effects-present-windowsAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: nate
Priority: NOR    
Version First Reported In: git master   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/kwin/commit/797bd80d0749e10b8fe1a864ab9f068e3746dad9 Version Fixed/Implemented In: 5.26
Sentry Crash Report:

Description ratijas 2022-09-16 23:24:38 UTC 
SUMMARY

WindowView effect's implementation binds this label's visibility to `heap.count === 0`, where `count` is a window heap's an alias to its Repeater::count property. Instead it should be kind of a visibleCount: something like a children and visibleChildren duo in Items.

STEPS TO REPRODUCE
1. Open at least one window on a desktop.
2. Minimize all windows.
3. Activate "Toggle Present Windows (Window class on current desktop)" action (Ctrl+F7 by default).

OBSERVED RESULT
Empty blurred screen.

EXPECTED RESULT
Placeholder with text "No Windows".

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE: git-master
Qt Version: 5.15.6
Kernel Version: 5.19.8-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-6700HQ CPU @ 2.60GHz
Memory: 31.3 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 970M/PCIe/SSE2
Manufacturer: ASUSTeK COMPUTER INC.
Product Name: G752VT
System Version: 1.0

ADDITIONAL INFORMATION
Note: Ctrl+F7 mode seems to be using special filtering technique, which is why this glitch isn't present (har har) in other flavors of this effect.
Comment 1 Bug Janitor Service 2022-09-16 23:41:35 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2964
Comment 2 ratijas 2022-09-20 10:34:23 UTC 
Git commit 8ac49010685b5b9883db53142be55ea08a0abae3 by ivan tkachenko.
Committed on 20/09/2022 at 09:35.
Pushed by ratijas into branch 'master'.

effects/windowview: Turn placeholder on when there are actually no visible windows

This may happen when all windows are minimized, and the effect was
started in "Window class on current desktop" mode (Ctrl+F7).
FIXED-IN: 5.26

M  +10   -0    src/effects/private/qml/WindowHeap.qml
M  +2    -1    src/effects/windowview/qml/main.qml

https://invent.kde.org/plasma/kwin/commit/8ac49010685b5b9883db53142be55ea08a0abae3
Comment 3 ratijas 2022-09-20 12:28:55 UTC 
Git commit 797bd80d0749e10b8fe1a864ab9f068e3746dad9 by ivan tkachenko.
Committed on 20/09/2022 at 12:27.
Pushed by ratijas into branch 'Plasma/5.26'.

effects/windowview: Turn placeholder on when there are actually no visible windows

This may happen when all windows are minimized, and the effect was
started in "Window class on current desktop" mode (Ctrl+F7).
FIXED-IN: 5.26
(cherry picked from commit 8ac49010685b5b9883db53142be55ea08a0abae3)

M  +10   -0    src/effects/private/qml/WindowHeap.qml
M  +2    -1    src/effects/windowview/qml/main.qml

https://invent.kde.org/plasma/kwin/commit/797bd80d0749e10b8fe1a864ab9f068e3746dad9