Bug 459224

Summary:	Cover art doesn't load
Product:	[Applications] Elisa	Reporter:	dawgsome7
Component:	general	Assignee:	Matthieu Gallien <matthieu_gallien>
Status:	REPORTED ---
Severity:	normal	CC:	nate, sancoder
Priority:	NOR
Version First Reported In:	22.08.0
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	A way to fix no covers bug

Description dawgsome7 2022-09-16 15:55:17 UTC

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Open Elisa
2. Let it scan my library of songs in the Music folder

OBSERVED RESULT
Album cover arts don't load

EXPECTED RESULT
They should though

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.25.4
KDE Frameworks Version: 5.97.0
Qt Version: 5.15.5

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2022-09-16 20:46:14 UTC

For nothing? Or for only some things?

How is the album art stored for your music? as standalone image files in the album folders, embedded into the individual music filed, both, or a mix of them?

Comment 2 dawgsome7 2022-09-17 05:31:12 UTC

(In reply to Nate Graham from comment #1)
> For nothing? Or for only some things?
For none of my files, while other music players detect them
> How is the album art stored for your music? as standalone image files in the
> album folders, embedded into the individual music filed, both, or a mix of
> them?
It is always embedded into the individual files

Comment 3 Nate Graham 2022-09-19 21:12:52 UTC

Strange, 22.08 was supposed to fix this, and it's working for me.

Are you using the fast native indexer, or the filesystem crawler indexer?

Comment 4 dawgsome7 2022-09-20 16:35:01 UTC

> Strange, 22.08 was supposed to fix this, and it's working for me.
> 
> Are you using the fast native indexer, or the filesystem crawler indexer?
I tried both, but my cover art still doesn't load

Comment 5 Nate Graham 2022-09-20 17:37:48 UTC

Ok, thanks for the info. Unfortunately I don't know what it could be caused by.

Comment 6 dawgsome7 2022-09-20 17:42:38 UTC

Ok, Well thanks anyways

Comment 7 sancoder 2023-07-07 02:15:30 UTC

Hit this bug. All albums have no covers in the "browser" part. Header bar and playlist panel show album cover images perfectly.
That was really strange as previously I was testing elisa on another Linux distro (Debian 12) and the player worked really great. Now on Gentoo, with @world update not so long ago (few days).

I never had experience with Qt before so forgive me my blatant method. But I fixed the problem by getting rid of CoverImage component in GridBrowserDelegate.qml. Instead, I just used ImageWithFallback directly. And the problem was solved.

I can test more appropriate solution if anyone would suggest another way to fix. It is always reproducible.

Comment 8 sancoder 2023-07-07 02:16:15 UTC

Created attachment 160112 [details]
A way to fix no covers bug

Comment 9 Nate Graham 2023-07-25 20:26:15 UTC

Would you consider submitting that as a Merge Request at https://invent.kde.org/multimedia/elisa/-/merge_requests? See also https://community.kde.org/Infrastructure/GitLab#Submitting_a_merge_request.

Comment 10 sancoder 2023-07-25 23:34:01 UTC

My patch is not a fix. It's a workaround. From what I understand if a folder contains several albums (for example a folder is all albums for an artist), then a cover image for this folder should look like for quarter images. My change breaks it, the folder now shows only one image. But for me (and those who is suffering from the same bug) it's a way to display at least something.