| Summary: | When opening again after having used the search last time, windows re-layout as if there was an invisible window somewhere | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Jin Liu <ad.liu.jin> |
| Component: | effects-overview | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | me, nate, postix |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | 5.25.90 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/36d93d6225a8ba5d4b16cc21cc4f029a7db2ee39 | Version Fixed In: | 5.26 |
| Sentry Crash Report: | |||
| Attachments: | screencast of the bug | ||
|
Description
Jin Liu
2022-09-16 05:23:24 UTC
Created attachment 152094 [details]
screencast of the bug
Seems this bug happens whenever the search box in Overview is used. STEPS TO REPRODUCE 1. Start Dolphin. 2. Trigger Overview effect. 3. Type "dolphin". Press Enter. 4. Trigger Overview effect again. OBSERVED RESULT Dolphin thumbnail first moves sideways, then moves to the center. EXPECTED RESULT The window is layouted correctly. Can reproduce with those steps! *assuming the voice of Bug Janitor* ahem… A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2965 I used a wrong BUG number at first, so now this needs to be managed manually. Git commit de6c0289a0798d1068362e14654feaf7451284dc by ivan tkachenko. Committed on 17/09/2022 at 11:44. Pushed by ratijas into branch 'master'. effects/overview: Implement the searchText backing property It is used in QML code, just like in windowview (Present Windows) effect, but developers forgot to copy the implementation in C++ backend. FIXED-IN: 5.26 M +2 -0 src/effects/overview/overvieweffect.cpp M +4 -1 src/effects/overview/overvieweffect.h M +3 -3 src/effects/windowview/windowvieweffect.cpp https://invent.kde.org/plasma/kwin/commit/de6c0289a0798d1068362e14654feaf7451284dc Git commit d7c6a87f395e5223f6b21b23438bd62e248f67b5 by ivan tkachenko. Committed on 17/09/2022 at 11:44. Pushed by ratijas into branch 'master'. effects/overview: Bind to search field using textEdited signal This special signal was designed to remove the need for such bikesheddings and workarounds. Use it to react to user-driven changes. FIXED-IN: 5.26 M +7 -12 src/effects/overview/qml/ScreenView.qml https://invent.kde.org/plasma/kwin/commit/d7c6a87f395e5223f6b21b23438bd62e248f67b5 Git commit e177f7b57ea773d76995636155f78cae10d2bb92 by ivan tkachenko. Committed on 17/09/2022 at 14:16. Pushed by ratijas into branch 'Plasma/5.26'. effects/overview: Implement the searchText backing property It is used in QML code, just like in windowview (Present Windows) effect, but developers forgot to copy the implementation in C++ backend. FIXED-IN: 5.26 (cherry picked from commit de6c0289a0798d1068362e14654feaf7451284dc) M +2 -0 src/effects/overview/overvieweffect.cpp M +4 -1 src/effects/overview/overvieweffect.h M +3 -3 src/effects/windowview/windowvieweffect.cpp https://invent.kde.org/plasma/kwin/commit/e177f7b57ea773d76995636155f78cae10d2bb92 Git commit 36d93d6225a8ba5d4b16cc21cc4f029a7db2ee39 by ivan tkachenko. Committed on 17/09/2022 at 14:16. Pushed by ratijas into branch 'Plasma/5.26'. effects/overview: Bind to search field using textEdited signal This special signal was designed to remove the need for such bikesheddings and workarounds. Use it to react to user-driven changes. FIXED-IN: 5.26 (cherry picked from commit d7c6a87f395e5223f6b21b23438bd62e248f67b5) M +7 -12 src/effects/overview/qml/ScreenView.qml https://invent.kde.org/plasma/kwin/commit/36d93d6225a8ba5d4b16cc21cc4f029a7db2ee39 |