| Summary: | Layer Panel: Selection Highlighting only works on Layers with a Color Label | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | michaelknubben |
| Component: | Layer Stack | Assignee: | Halla Rempt <halla> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | halla, tomtomtomreportingin |
| Priority: | NOR | ||
| Version: | 5.1.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/7fefaf5a5ecb9db1691eff724900797b08814d55 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
michaelknubben
2022-09-15 11:22:30 UTC
Yes, I see this happen, but I'm not sure it's a bug, it might even have been intentional, to draw attention to the labeled layers specifically. If you ask me, the color is meant to draw attention to that fact :D I don't think this is consistent. Personally I'd prefer no highlighting at all, but either way: I don't see why it wouldn't apply to all layers equally. I even switched themes to see if it was just a matter of the wrong colour being used for the non-labeled layers, but nope. If this is going to go either way, I would prefer the color hover-highlight to not exist. Messes with text contrast a bit. I agree, it's not needed, and there's no such highlighting elsewhere I can think of. Curiously, this seems to have been added in a commit that was supposed to only improve support for RTL: commit 097d7e617aa260d467f86e65f8c6edfdd6124ea9 Author: Safa AlFulaij <safa1996alfulaij@gmail.com>, Tue Sep 18 16:55:21 2018 +0300 (4 years ago) Committer: Safa AlFulaij <safa1996alfulaij@gmail.com>, Sun Jan 13 15:36:57 2019 +0300 (3 years, 8 months ago) Follows: v4.2.0-prealpha Precedes: 4.2.0-pre-alpha-HDR Branches: <Expand> Refactor KisNodeDelegate and support RTL Git commit 5943e6eaa652f2ec36f59c79a4f8accb47239ced by Halla Rempt. Committed on 16/09/2022 at 08:54. Pushed by rempt into branch 'master'. Don't highlight a layer with a color label on mouse-over This was added in commit 097d7e617aa260d467f86e65f8c6edfdd6124ea9 Author: Safa AlFulaij <safa1996alfulaij@gmail.com>, Tue Sep 18 16:55:21 2018 +0300 (4 years ago) Committer: Safa AlFulaij <safa1996alfulaij@gmail.com>, Sun Jan 13 15:36:57 2019 +0300 (3 years, 8 months ago) Follows: v4.2.0-prealpha Precedes: 4.2.0-pre-alpha-HDR Branches: <Expand> Refactor KisNodeDelegate and support RTL Which wasn't meant to create visual changes to the node delegate, only to fix RTL. This restores the old layer blending. M +1 -5 plugins/dockers/layerdocker/NodeDelegate.cpp https://invent.kde.org/graphics/krita/commit/5943e6eaa652f2ec36f59c79a4f8accb47239ced Git commit 7fefaf5a5ecb9db1691eff724900797b08814d55 by Halla Rempt. Committed on 16/09/2022 at 08:55. Pushed by rempt into branch 'krita/5.1'. Don't highlight a layer with a color label on mouse-over This was added in commit 097d7e617aa260d467f86e65f8c6edfdd6124ea9 Author: Safa AlFulaij <safa1996alfulaij@gmail.com>, Tue Sep 18 16:55:21 2018 +0300 (4 years ago) Committer: Safa AlFulaij <safa1996alfulaij@gmail.com>, Sun Jan 13 15:36:57 2019 +0300 (3 years, 8 months ago) Follows: v4.2.0-prealpha Precedes: 4.2.0-pre-alpha-HDR Branches: <Expand> Refactor KisNodeDelegate and support RTL Which wasn't meant to create visual changes to the node delegate, only to fix RTL. This restores the old layer blending. (cherry picked from commit 5943e6eaa652f2ec36f59c79a4f8accb47239ced) M +1 -5 plugins/dockers/layerdocker/NodeDelegate.cpp https://invent.kde.org/graphics/krita/commit/7fefaf5a5ecb9db1691eff724900797b08814d55 Great, thanks for resolving this, Halla! |