Bug 459093

Summary: Unable to configure syntax highlight themes
Product: [Applications] kate Reporter: Laura David Hurka <laura.stern>
Component: generalAssignee: KWrite Developers <kwrite-bugs-null>
Status: CONFIRMED ---    
Severity: normal CC: christoph, laura.stern
Priority: NOR    
Version First Reported In: 22.08.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Configuration dialog

Description Laura David Hurka 2022-09-14 10:59:42 UTC
Created attachment 152047 [details]
Configuration dialog

SUMMARY
I noticed that the default highlighting theme for Lua has changed, and tried to change it back to what I am used to.
In the configuration dialog I noticed that there were minor changes to the GUI.

The new GUI does not work.
Most changes to highlighting themes are immediately undone by the configuration dialog, and other changes simply have no effect.

STEPS TO REPRODUCE
1. Open a code file.
2. Open configuration dialog -> Color Themes -> Theme Editor -> Highlighting Text Styles.
3. Copy the Breeze Light theme, so editing is allowed.
4. Select a line, like “Keyword”.
5. Uncheck the “Bold” checkbox.
6. Check the “Italic” checkbox.
7. Uncheck the “Use Default Style” checkbox.
8. Click “Normal” to change the text color, choose a different color.
9. Repeat steps 5 and 6.
10. Close configuration dialog.

OBSERVED RESULT
3. New theme is created, and can be selected from menu bar -> Settings -> Syntax Hightlight Theme.
5. The “Bold” checkbox is immediately checked again when I click anywhere else.
6. The “Italic” checkbox keeps its new state, but is reset when I click “Apply”.
7. Can not be toggled. A message box tells me that it is changed automatically when I change other settings.
8. Colors can be changed, and the “Use Default Style” checkbox is indeed unchecked automatically.
9. The “Bold” checkbox can now be toggled, and the “Italic” checkbox even keeps its state after clicking “Apply”.
10. After selecting the new theme from the menu bar, no changes at all are visible.

EXPECTED RESULT
5. and 6. The checkboxes can be toggled, and “Use Default Style” is automatically unchecked. Clicking “Apply” does not reset the checkboxes.
10. After selecting the new theme, it is actually used.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.25
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.97.0
Qt Version: 5.15.5
Comment 1 Christoph Cullmann 2023-04-29 18:11:07 UTC
I think I see the issue, will take care of it.
Comment 2 Bug Janitor Service 2023-04-29 18:58:04 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/546
Comment 3 Christoph Cullmann 2024-03-10 16:22:49 UTC
Git commit 42d3ebc1023f830ceee046b0f441ba26acfcd3ce by Christoph Cullmann.
Committed on 10/03/2024 at 16:04.
Pushed by cullmann into branch 'master'.

try to save changes

M  +15   -8    src/syntax/katethemeconfig.cpp

https://invent.kde.org/frameworks/ktexteditor/-/commit/42d3ebc1023f830ceee046b0f441ba26acfcd3ce